Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: chrome/test/webdriver/commands/command.h

Issue 6532068: Fix a bug in ImplicitWaitCommand: we must explicitly check if the ms param... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Reverting changes added while debugging Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/command.h
===================================================================
--- chrome/test/webdriver/commands/command.h (revision 75464)
+++ chrome/test/webdriver/commands/command.h (working copy)
@@ -54,6 +54,9 @@
return i < path_segments_.size() ? path_segments_.at(i) : "";
}
+ // Returns whether the command has a parameter with the given |key|.
+ bool HasParameter(const std::string& key) const;
+
// Returns true if the command parameter with the given |key| exists and is
// a null value.
bool IsNullParameter(const std::string& key) const;
@@ -78,6 +81,10 @@
// false if there is no such parameter, or if it is not a int.
bool GetIntegerParameter(const std::string& key, int* out) const;
+ // Provides the command parameter with the given |key| as a double. Returns
+ // false if there is no such parameter, or if it is not a dobule.
+ bool GetDoubleParameter(const std::string& key, double* out) const;
+
// Provides the command parameter with the given |key| as a Dictionary.
// Returns false if there is no such parameter, or if it is not a Dictionary.
bool GetDictionaryParameter(const std::string& key,

Powered by Google App Engine
This is Rietveld 408576698