Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/test/webdriver/commands/command.cc

Issue 6532068: Fix a bug in ImplicitWaitCommand: we must explicitly check if the ms param... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Reverting changes added while debugging Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/command.cc
===================================================================
--- chrome/test/webdriver/commands/command.cc (revision 75464)
+++ chrome/test/webdriver/commands/command.cc (working copy)
@@ -40,6 +40,10 @@
return true;
}
+bool Command::HasParameter(const std::string& key) const {
+ return parameters_.get() && parameters_->HasKey(key);
+}
+
bool Command::IsNullParameter(const std::string& key) const {
Value* value;
return parameters_.get() &&
@@ -72,6 +76,10 @@
return parameters_.get() != NULL && parameters_->GetInteger(key, out);
}
+bool Command::GetDoubleParameter(const std::string& key, double* out) const {
+ return parameters_.get() != NULL && parameters_->GetDouble(key, out);
+}
+
bool Command::GetDictionaryParameter(const std::string& key,
DictionaryValue** out) const {
return parameters_.get() != NULL && parameters_->GetDictionary(key, out);

Powered by Google App Engine
This is Rietveld 408576698