Pass in the HostContentSettingsMap to the CookieModalDialog so IsValid can ma...

Pass in the HostContentSettingsMap to the CookieModalDialog so IsValid can make its decision.  Before, it used the TabContents to get the profile to get the map, but this was incorrect because the current tab isn't necessarily from the same profile as the original request.

As long as we have the HostContentSettingsMap, we might as well handle "remember" in CookieModalDialog.

This bug exists in 4.1.

TEST=none
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39558

[sky, 2010-02-19 16:07:38]

LGTM

http://codereview.chromium.org/651023/diff/1/10
File chrome/browser/cookie_modal_dialog.h (right):

http://codereview.chromium.org/651023/diff/1/10#newcode32
chrome/browser/cookie_modal_dialog.h:32: HostContentSettingsMap*
host_content_settings_map,
Can you forward declare HostContentSettingsMap?

http://codereview.chromium.org/651023/diff/1/10#newcode79
chrome/browser/cookie_modal_dialog.h:79: scoped_refptr<HostContentSettingsMap>
host_content_settings_map_;
Do you need to include base/ref_counted?

[jorlow, 2010-02-19 16:34:46]

New version uploaded.

http://codereview.chromium.org/651023/diff/1/10
File chrome/browser/cookie_modal_dialog.h (right):

http://codereview.chromium.org/651023/diff/1/10#newcode32
chrome/browser/cookie_modal_dialog.h:32: HostContentSettingsMap*
host_content_settings_map,
On 2010/02/19 16:07:38, sky wrote:
> Can you forward declare HostContentSettingsMap?

If I put the destructor in the .cc....done.

http://codereview.chromium.org/651023/diff/1/10#newcode79
chrome/browser/cookie_modal_dialog.h:79: scoped_refptr<HostContentSettingsMap>
host_content_settings_map_;
On 2010/02/19 16:07:38, sky wrote:
> Do you need to include base/ref_counted?

Something else does implicitly...but why not.

[darin (slow to review), 2010-02-19 17:54:25]

LGTM, except:

http://codereview.chromium.org/651023/diff/22/1031
File chrome/browser/net/chrome_cookie_policy.cc (right):

http://codereview.chromium.org/651023/diff/22/1031#newcode45
chrome/browser/net/chrome_cookie_policy.cc:45: NotifyDone(session_expire ?
net::OK_FOR_SESSION_ONLY : net::OK);
this will not compile on linux/mac because GCC will complain that these are from
separate enums, which they are.  you'll need to use the code as it was.