Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8103)

Unified Diff: chrome/browser/in_process_webkit/dom_storage_permission_request.cc

Issue 651023: Pass in the HostContentSettingsMap to the CookieModalDialog so IsValid can ma... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/in_process_webkit/dom_storage_permission_request.cc
===================================================================
--- chrome/browser/in_process_webkit/dom_storage_permission_request.cc (revision 39556)
+++ chrome/browser/in_process_webkit/dom_storage_permission_request.cc (working copy)
@@ -26,53 +26,44 @@
// static
void DOMStoragePermissionRequest::PromptUser(
- DOMStoragePermissionRequest* dom_storage_permission_request) {
+ DOMStoragePermissionRequest* request) {
DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
// Cookie settings may have changed.
ContentSetting setting =
- dom_storage_permission_request->host_content_settings_map_->
- GetContentSetting(dom_storage_permission_request->url(),
- CONTENT_SETTINGS_TYPE_COOKIES);
+ request->host_content_settings_map_->GetContentSetting(
+ request->url_, CONTENT_SETTINGS_TYPE_COOKIES);
if (setting != CONTENT_SETTING_ASK) {
- dom_storage_permission_request->SendResponse(setting, false);
+ request->SendResponse(setting);
return;
}
Browser* browser = BrowserList::GetLastActive();
if (!browser || !browser->GetSelectedTabContents()) {
- dom_storage_permission_request->SendResponse(CONTENT_SETTING_BLOCK, false);
+ request->SendResponse(CONTENT_SETTING_BLOCK);
return;
}
#if defined(OS_WIN)
RunLocalStoragePrompt(browser->GetSelectedTabContents(),
- dom_storage_permission_request->url(),
- dom_storage_permission_request->key(),
- dom_storage_permission_request->value(),
- dom_storage_permission_request);
+ request->host_content_settings_map_, request->url_,
+ request->key_, request->value_, request);
#else
// TODO(darin): Enable prompting for other ports.
- dom_storage_permission_request->SendResponse(CONTENT_SETTING_BLOCK, false);
+ request->SendResponse(CONTENT_SETTING_BLOCK);
#endif
}
-void DOMStoragePermissionRequest::AllowSiteData(bool remember,
- bool session_expire) {
- // The session_expire parameter is not relevant.
- SendResponse(CONTENT_SETTING_ALLOW, remember);
+void DOMStoragePermissionRequest::AllowSiteData(bool session_expire) {
+ SendResponse(CONTENT_SETTING_ALLOW);
}
-void DOMStoragePermissionRequest::BlockSiteData(bool remember) {
- SendResponse(CONTENT_SETTING_BLOCK, remember);
+void DOMStoragePermissionRequest::BlockSiteData() {
+ SendResponse(CONTENT_SETTING_BLOCK);
}
-void DOMStoragePermissionRequest::SendResponse(ContentSetting content_setting,
- bool remember) {
+void DOMStoragePermissionRequest::SendResponse(
+ ContentSetting content_setting) {
response_content_setting_ = content_setting;
- if (remember) {
- host_content_settings_map_->SetContentSetting(
- url_.host(), CONTENT_SETTINGS_TYPE_COOKIES, content_setting);
- }
event_.Signal();
}
« no previous file with comments | « chrome/browser/in_process_webkit/dom_storage_permission_request.h ('k') | chrome/browser/message_box_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698