Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3253)

Unified Diff: chrome/browser/renderer_host/database_permission_request.cc

Issue 651023: Pass in the HostContentSettingsMap to the CookieModalDialog so IsValid can ma... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/database_permission_request.cc
===================================================================
--- chrome/browser/renderer_host/database_permission_request.cc (revision 39556)
+++ chrome/browser/renderer_host/database_permission_request.cc (working copy)
@@ -41,13 +41,13 @@
ContentSetting setting = host_content_settings_map_->GetContentSetting(
url_, CONTENT_SETTINGS_TYPE_COOKIES);
if (setting != CONTENT_SETTING_ASK) {
- SendResponse(setting, false);
+ SendResponse(setting);
return;
}
Browser* browser = BrowserList::GetLastActive();
if (!browser || !browser->GetSelectedTabContents()) {
- BlockSiteData(false);
+ BlockSiteData();
return;
}
@@ -55,30 +55,23 @@
self_ref_ = this;
// Will call either AllowSiteData or BlockSiteData which will NULL out our
// self reference.
- RunDatabasePrompt(browser->GetSelectedTabContents(), url_,
- database_name_, this);
+ RunDatabasePrompt(browser->GetSelectedTabContents(),
+ host_content_settings_map_, url_, database_name_, this);
#else
// TODO(jorlow): Enable prompting for other ports.
- BlockSiteData(false);
+ BlockSiteData();
#endif
}
-void DatabasePermissionRequest::AllowSiteData(bool remember,
- bool session_expire) {
- SendResponse(CONTENT_SETTING_ALLOW, remember);
+void DatabasePermissionRequest::AllowSiteData(bool session_expire) {
+ SendResponse(CONTENT_SETTING_ALLOW);
}
-void DatabasePermissionRequest::BlockSiteData(bool remember) {
- SendResponse(CONTENT_SETTING_BLOCK, remember);
+void DatabasePermissionRequest::BlockSiteData() {
+ SendResponse(CONTENT_SETTING_BLOCK);
}
-void DatabasePermissionRequest::SendResponse(ContentSetting content_setting,
- bool remember) {
- if (remember) {
- host_content_settings_map_->SetContentSetting(
- url_.host(), CONTENT_SETTINGS_TYPE_COOKIES, content_setting);
- }
-
+void DatabasePermissionRequest::SendResponse(ContentSetting content_setting) {
if (content_setting == CONTENT_SETTING_ALLOW) {
ChromeThread::PostTask(ChromeThread::IO, FROM_HERE, on_allow_.release());
} else {
« no previous file with comments | « chrome/browser/renderer_host/database_permission_request.h ('k') | chrome/browser/views/cookie_prompt_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698