DOM UI options handler cleanup:

chrome/browser/dom_ui/options/dom_options_util.cc

Index: chrome/browser/dom_ui/options/dom_options_util.cc
diff --git a/chrome/browser/dom_ui/options/dom_options_util.cc b/chrome/browser/dom_ui/options/dom_options_util.cc
index f528a47746800761a7f1e09f29f2767eadfece11..164eceaa70da0c2667cdbe49f313d41fe647e71c 100644
--- a/chrome/browser/dom_ui/options/dom_options_util.cc
+++ b/chrome/browser/dom_ui/options/dom_options_util.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -9,9 +9,11 @@
 namespace dom_options_util {
 
 string16 StripColon(const string16& str) {
-  const string16::value_type kColon[] = {':',0};
+  const string16::value_type kColon[] = { ':', 0 };

[Mike Mammarella, 2011/02/11 18:38:48]

Doesn't the style guide say not to use spaces after { and before } here? (The
sawzall style guide requires them, but I think C++ says not to.)

[Evan Stade, 2011/02/11 19:23:33]

optional, apparently:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Horizo...

but I believe using them is more common than not within chrome's codebase

[Mike Mammarella, 2011/02/11 20:56:19]

OK then.

   string16 result;
-  RemoveChars(str, kColon, &result);
+  bool stripped = TrimString(str, kColon, &result);
+  // We shouldn't be called on strings without trailing colons.
+  DCHECK(stripped);
   return result;
 }