DOM UI options handler cleanup:

chrome/browser/dom_ui/options/advanced_options_handler.cc

Index: chrome/browser/dom_ui/options/advanced_options_handler.cc
diff --git a/chrome/browser/dom_ui/options/advanced_options_handler.cc b/chrome/browser/dom_ui/options/advanced_options_handler.cc
index f8cfcb11e6229d82cbb17972bceb9a90954263ff..f6b11c7f7cc6ee8bf5cdb5ce6de9eb13372eeb0a 100644
--- a/chrome/browser/dom_ui/options/advanced_options_handler.cc
+++ b/chrome/browser/dom_ui/options/advanced_options_handler.cc
@@ -57,6 +57,7 @@ AdvancedOptionsHandler::AdvancedOptionsHandler() {
       CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableCloudPrintProxy);
 #endif
+  cloud_print_proxy_ui_enabled_ = true;
 }
 
 AdvancedOptionsHandler::~AdvancedOptionsHandler() {
@@ -66,7 +67,7 @@ void AdvancedOptionsHandler::GetLocalizedValues(
     DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
 
-  OptionsStringResource resources[] = {
+  static OptionsStringResource resources[] = {
     { "downloadLocationGroupName",
       IDS_OPTIONS_DOWNLOADLOCATION_GROUP_NAME },
     { "downloadLocationChangeButton",
@@ -187,9 +188,8 @@ void AdvancedOptionsHandler::GetLocalizedValues(
 #if !defined(OS_CHROMEOS)
   // Add the cloud print proxy management ui section if it's been runtime
   // enabled.
-  localized_strings->SetString(
-      "enable-cloud-print-proxy",
-      cloud_print_proxy_ui_enabled_ ? "true" : "false" );
+  localized_strings->SetBoolean("enable-cloud-print-proxy",
+                                cloud_print_proxy_ui_enabled_);
 #endif
 }
 
@@ -376,7 +376,7 @@ void AdvancedOptionsHandler::HandleMetricsReportingCheckbox(
     const ListValue* args) {
 #if defined(GOOGLE_CHROME_BUILD) && !defined(OS_CHROMEOS)
   std::string checked_str = WideToUTF8(ExtractStringValue(args));
-  bool enabled = (checked_str == "true");

[Mike Mammarella, 2011/02/11 18:38:48]

Personally I like these parens, because they make it clear that I'm not
assigning checked_str to enabled and then comparing the result to "true" and
throwing that away. In this case the types make that mostly clear, but you never
can tell what C++ might do with implicit conversions and such...

Does clang really not like them usually?

[Evan Stade, 2011/02/11 19:23:33]

well, I think clang would complain, but I guess I'm not positive. When an
assignment is used as a truth value, g++ warns unless you put extra parens
around it (to prove you really mean it). Transversely, extra parens around a
comparison could indicate that you meant to do an assignment, so clang warns.

What I'm not positive about is if assigning to a bool variable counts the same
as a truth value in the context of if().

p.s. what makes this clear for me is operator precedence, not the types

[Mike Mammarella, 2011/02/11 20:56:19]

Yeah, there are just some operators that I don't always remember the precedence
of, and that I've gotten wrong in the past, so I tend to try and avoid counting
on anything other than the simple ones that everybody remembers. Maybe I'm just
weird in not remembering = vs ==...

Overall LGTM in any event.

+  bool enabled = checked_str == "true";
   UserMetricsRecordAction(
       enabled ?
           UserMetricsAction("Options_MetricsReportingCheckbox_Enable") :
@@ -402,7 +402,7 @@ void AdvancedOptionsHandler::HandleDefaultFontSize(const ListValue* args) {
 void AdvancedOptionsHandler::HandleCheckRevocationCheckbox(
     const ListValue* args) {
   std::string checked_str = WideToUTF8(ExtractStringValue(args));
-  bool enabled = (checked_str == "true");
+  bool enabled = checked_str == "true";
   std::string metric =
       (enabled ? "Options_CheckCertRevocation_Enable"
                : "Options_CheckCertRevocation_Disable");
@@ -412,7 +412,7 @@ void AdvancedOptionsHandler::HandleCheckRevocationCheckbox(
 
 void AdvancedOptionsHandler::HandleUseSSL3Checkbox(const ListValue* args) {
   std::string checked_str = WideToUTF8(ExtractStringValue(args));
-  bool enabled = (checked_str == "true");
+  bool enabled = checked_str == "true";
   std::string metric =
       (enabled ? "Options_SSL3_Enable" : "Options_SSL3_Disable");
   UserMetricsRecordAction(UserMetricsAction(metric.c_str()));
@@ -421,7 +421,7 @@ void AdvancedOptionsHandler::HandleUseSSL3Checkbox(const ListValue* args) {
 
 void AdvancedOptionsHandler::HandleUseTLS1Checkbox(const ListValue* args) {
   std::string checked_str = WideToUTF8(ExtractStringValue(args));
-  bool enabled = (checked_str == "true");
+  bool enabled = checked_str == "true";
   std::string metric =
       (enabled ? "Options_TLS1_Enable" : "Options_TLS1_Disable");
   UserMetricsRecordAction(UserMetricsAction(metric.c_str()));