chrome/browser/dom_ui/options/dom_options_util.cc - Issue 6490016: DOM UI options handler cleanup:

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/dom_ui/options/dom_options_util.cc

Issue 6490016: DOM UI options handler cleanup: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: indent Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/dom_ui/options/advanced_options_handler.cc ('K') | « chrome/browser/dom_ui/options/content_settings_handler.cc ('k') | chrome/browser/dom_ui/options/language_options_handler_common.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/dom_ui/options/dom_options_util.h"	5 #include "chrome/browser/dom_ui/options/dom_options_util.h"

6	6

7 #include "base/string_util.h"	7 #include "base/string_util.h"

8	8

9 namespace dom_options_util {	9 namespace dom_options_util {

10	10

11 string16 StripColon(const string16& str) {	11 string16 StripColon(const string16& str) {

12 const string16::value_type kColon[] = {':',0};	12 const string16::value_type kColon[] = { ':', 0 };
	Mike Mammarella 2011/02/11 18:38:48 Doesn't the style guide say not to use spaces afte Doesn't the style guide say not to use spaces after { and before } here? (The sawzall style guide requires them, but I think C++ says not to.) Evan Stade 2011/02/11 19:23:33 optional, apparently: http://google-styleguide.goo Show quoted text On 2011/02/11 18:38:48, Mike Mammarella wrote: > Doesn't the style guide say not to use spaces after { and before } here? (The > sawzall style guide requires them, but I think C++ says not to.) optional, apparently: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Horizo... but I believe using them is more common than not within chrome's codebase Mike Mammarella 2011/02/11 20:56:19 OK then. Show quoted text On 2011/02/11 19:23:33, Evan Stade wrote: > On 2011/02/11 18:38:48, Mike Mammarella wrote: > > Doesn't the style guide say not to use spaces after { and before } here? (The > > sawzall style guide requires them, but I think C++ says not to.) > > optional, apparently: > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Horizo... > > but I believe using them is more common than not within chrome's codebase OK then.
13 string16 result;	13 string16 result;

14 RemoveChars(str, kColon, &result);	14 bool stripped = TrimString(str, kColon, &result);

	15 // We shouldn't be called on strings without trailing colons.

	16 DCHECK(stripped);

15 return result;	17 return result;

16 }	18 }

17	19

18 } // namespace dom_options_util	20 } // namespace dom_options_util

OLD	NEW