Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent... (Closed)

Created:
9 years, 11 months ago by Aleksey Shlyapnikov
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Only allow extension pages to be displayed in the sidebar to be consistent with the rest of the extension system. Change extension manifest "sidebar" section and sidebar API accordingly: "sidebar": { "default_icon": "", "default_page": "", "default_title": "" } chrome.experimental.sidebar.navigate({tabId: ..., path: ...}) BUG=51084 TEST=browser_tests::Sidebar.*, unit_tests::ExtensionManifestTest.Sidebar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72514

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -166 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_sidebar_api.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sidebar/sidebar_container.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sidebar/sidebar_container.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/experimental.sidebar.html View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension.cc View 3 chunks +27 lines, -27 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/common/extensions/extension_sidebar_defaults.h View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/common/extensions/extension_sidebar_utils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_sidebar_utils.cc View 2 chunks +5 lines, -32 lines 0 comments Download
M chrome/test/data/extensions/api_test/sidebar/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/manifest_tests/sidebar.json View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/sidebar_external_url.json View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/sidebar_icon_empty.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/manifest_tests/sidebar_icon_invalid_type.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/manifest_tests/sidebar_no_permissions.json View 1 chunk +1 line, -4 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/sidebar_page_empty.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/sidebar_page_invalid_type.json View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/sidebar_title_invalid_type.json View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/sidebar_url_invalid.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/sidebar_url_invalid_type.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/sidebar_url_no_permissions.json View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Aleksey Shlyapnikov
9 years, 11 months ago (2011-01-22 00:02:28 UTC) #1
Aaron Boodman
http://codereview.chromium.org/6378009/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/6378009/diff/1/chrome/common/extensions/extension.cc#newcode840 chrome/common/extensions/extension.cc:840: if (extension_sidebar->HasKey(keys::kSidebarDefaultPage)) { You should also validate that this ...
9 years, 11 months ago (2011-01-24 19:57:49 UTC) #2
Aleksey Shlyapnikov
http://codereview.chromium.org/6378009/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/6378009/diff/1/chrome/common/extensions/extension.cc#newcode840 chrome/common/extensions/extension.cc:840: if (extension_sidebar->HasKey(keys::kSidebarDefaultPage)) { On 2011/01/24 19:57:49, Aaron Boodman wrote: ...
9 years, 11 months ago (2011-01-24 21:29:03 UTC) #3
Aaron Boodman
9 years, 11 months ago (2011-01-24 22:25:11 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698