Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2938)

Unified Diff: chrome/common/extensions/extension_constants.cc

Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_constants.cc
===================================================================
--- chrome/common/extensions/extension_constants.cc (revision 72219)
+++ chrome/common/extensions/extension_constants.cc (working copy)
@@ -54,8 +54,8 @@
const char* kRunAt = "run_at";
const char* kSidebar = "sidebar";
const char* kSidebarDefaultIcon = "default_icon";
+const char* kSidebarDefaultPage = "default_page";
const char* kSidebarDefaultTitle = "default_title";
-const char* kSidebarDefaultUrl = "default_url";
const char* kSignature = "signature";
const char* kTheme = "theme";
const char* kThemeColors = "colors";
@@ -233,10 +233,10 @@
"Invalid value for 'sidebar'.";
const char* kInvalidSidebarDefaultIconPath =
"Invalid value for 'sidebar.default_icon'.";
+const char* kInvalidSidebarDefaultPage =
+ "Invalid value for 'sidebar.default_page'.";
const char* kInvalidSidebarDefaultTitle =
"Invalid value for 'sidebar.default_title'.";
-const char* kInvalidSidebarDefaultUrl =
- "Invalid value for 'sidebar.default_url'.";
const char* kInvalidSignature =
"Value 'signature' is missing or invalid.";
const char* kInvalidTheme =
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698