Only allow extension pages to be displayed in the sidebar to be consistent...

chrome/common/extensions/extension_file_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_file_util.h"
 
 #include <map>
 #include <vector>
 
 #include "app/l10n_util.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_action.h"
 #include "chrome/common/extensions/extension_l10n_util.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_resource.h"
+#include "chrome/common/extensions/extension_sidebar_defaults.h"
 #include "chrome/common/json_value_serializer.h"
 #include "grit/generated_resources.h"
 #include "net/base/escape.h"
 #include "net/base/file_stream.h"
 
 namespace errors = extension_manifest_errors;
 
 namespace extension_file_util {
 
 // Validates locale info. Doesn't check if messages.json files are valid.
@@ skipping 228 matching lines @@
     const FilePath path = extension->GetResource(options_path).GetFilePath();
     if (path.empty() || !file_util::PathExists(path)) {
       *error =
           l10n_util::GetStringFUTF8(
               IDS_EXTENSION_LOAD_OPTIONS_PAGE_FAILED,
               WideToUTF16(options_path.ToWStringHack()));
       return false;
     }
   }
 
+  // Validate sidebar default page location.
+  ExtensionSidebarDefaults* sidebar_defaults = extension->sidebar_defaults();
+  if (sidebar_defaults && sidebar_defaults->default_page().is_valid()) {
+    FilePath page_path = ExtensionURLToRelativeFilePath(
+        sidebar_defaults->default_page());
+    const FilePath path = extension->GetResource(page_path).GetFilePath();
+    if (path.empty() || !file_util::PathExists(path)) {
+      *error =
+          l10n_util::GetStringFUTF8(
+              IDS_EXTENSION_LOAD_SIDEBAR_PAGE_FAILED,
+              WideToUTF16(page_path.ToWStringHack()));
+      return false;
+    }
+  }
+
   // Validate locale info.
   if (!ValidateLocaleInfo(*extension, error))
     return false;
 
   // Check children of extension root to see if any of them start with _ and is
   // not on the reserved list.
   if (!CheckForIllegalFilenames(extension->path(), error)) {
     return false;
   }
 
@@ skipping 299 matching lines @@
                             result,
                             NUM_DIRECTORY_CREATION_RESULTS);
 
   if (result == SUCCESS)
     return temp_path;
 
   return FilePath();
 }
 
 }  // namespace extension_file_util