chrome/renderer/autofill_helper.h - Issue 6366019: Part 1 of repairing regressions to my old clang check plugins so Nico can

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill_helper.h

Issue 6366019: Part 1 of repairing regressions to my old clang check plugins so Nico can (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove Nico's changes that I patched in for testing. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/net/gaia/gaia_auth_consumer.h ('K') | « chrome/common/socket_stream_dispatcher.h ('k') | chrome/renderer/autofill_helper.cc » ('j') | chrome/renderer/device_orientation_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill_helper.h

diff --git a/chrome/renderer/autofill_helper.h b/chrome/renderer/autofill_helper.h

index 442b8881990145525b09fa5131e03a639ab3e917..c26ff8063a6f84c56f03cdcf2ecd62bf6c5e4d36 100644

--- a/chrome/renderer/autofill_helper.h

+++ b/chrome/renderer/autofill_helper.h

@@ -33,6 +33,7 @@ class AutoFillHelper : public RenderViewObserver,

// PasswordAutocompleteManager is guaranteed to outlive AutoFillHelper.

AutoFillHelper(RenderView* render_view,

PasswordAutocompleteManager* password_autocomplete_manager);

+ virtual ~AutoFillHelper();

Nico 2011/01/27 03:55:17 we don't usually say |virtual| for destructors in

Elliot Glaysher 2011/01/27 18:48:05 Not only do we usually do this, but one of my chec

// WebKit::WebAutoFillClient implementation. Public for tests.

virtual void didAcceptAutoFillSuggestion(const WebKit::WebNode& node,