Part 1 of repairing regressions to my old clang check plugins so Nico can

chrome/renderer/autofill_helper.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_AUTOFILL_HELPER_H_
 #define CHROME_RENDERER_AUTOFILL_HELPER_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 15 matching lines @@
 // - single text field suggestions, that we usually refer to as Autocomplete
 // - entire form fill based on one field entry, referred to as form AutoFill.
 
 class AutoFillHelper : public RenderViewObserver,
                        public PageClickListener,
                        public WebKit::WebAutoFillClient {
  public:
   // PasswordAutocompleteManager is guaranteed to outlive AutoFillHelper.
   AutoFillHelper(RenderView* render_view,
                  PasswordAutocompleteManager* password_autocomplete_manager);
+  virtual ~AutoFillHelper();

[Nico, 2011/01/27 03:55:17]

we don't usually say |virtual| for destructors in non-base classes, do we?

[Elliot Glaysher, 2011/01/27 18:48:05]

Not only do we usually do this, but one of my checks is to warn on methods that
are virtual but aren't declared as virtual.

 
   // WebKit::WebAutoFillClient implementation.  Public for tests.
   virtual void didAcceptAutoFillSuggestion(const WebKit::WebNode& node,
                                            const WebKit::WebString& value,
                                            const WebKit::WebString& label,
                                            int unique_id,
                                            unsigned index);
   virtual void didSelectAutoFillSuggestion(const WebKit::WebNode& node,
                                            const WebKit::WebString& value,
                                            const WebKit::WebString& label,
@@ skipping 101 matching lines @@
 
   // The menu index of the "AutoFill options..." menu item.
   int suggestions_options_index_;
 
   ScopedRunnableMethodFactory<AutoFillHelper> method_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutoFillHelper);
 };
 
 #endif  // CHROME_RENDERER_AUTOFILL_HELPER_H_