Part 1 of repairing regressions to my old clang check plugins so Nico can

chrome/common/net/gaia/gaia_auth_consumer.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_NET_GAIA_GAIA_AUTH_CONSUMER_H_
 #define CHROME_COMMON_NET_GAIA_GAIA_AUTH_CONSUMER_H_
 #pragma once
 
 #include <string>
 
 class GoogleServiceAuthError;
 
 // An interface that defines the callbacks for objects that
 // GaiaAuthFetcher can return data to.
 class GaiaAuthConsumer {
  public:
   struct ClientLoginResult {
-    inline ClientLoginResult() : two_factor(false) {}

[Nico, 2011/01/27 03:55:17]

lol inline

but since it's mentioned explicitly, maybe add whoever added this as reviewer,
just in case

-    inline ClientLoginResult(const std::string& new_sid,
-                             const std::string& new_lsid,
-                             const std::string& new_token,
-                             const std::string& new_data)
-        : sid(new_sid),
-          lsid(new_lsid),
-          token(new_token),
-          data(new_data),
-          two_factor(false) {}
+    ClientLoginResult();
+    ClientLoginResult(const std::string& new_sid,
+                      const std::string& new_lsid,
+                      const std::string& new_token,
+                      const std::string& new_data);
+    ~ClientLoginResult();
 
-    inline bool operator==(const ClientLoginResult &b) const {
-      return sid == b.sid &&
-             lsid == b.lsid &&
-             token == b.token &&
-             data == b.data &&
-             two_factor == b.two_factor;
-    }
+    bool operator==(const ClientLoginResult &b) const;
 
     std::string sid;
     std::string lsid;
     std::string token;
     // TODO(chron): Remove the data field later. Don't use it if possible.
     std::string data;  // Full contents of ClientLogin return.
     bool two_factor;  // set to true if there was a TWO_FACTOR "failure".
   };
 
   virtual ~GaiaAuthConsumer() {}
 
   virtual void OnClientLoginSuccess(const ClientLoginResult& result) {}
   virtual void OnClientLoginFailure(const GoogleServiceAuthError& error) {}
 
   virtual void OnIssueAuthTokenSuccess(const std::string& service,
                                        const std::string& auth_token) {}
   virtual void OnIssueAuthTokenFailure(const std::string& service,
                                        const GoogleServiceAuthError& error) {}
 
   virtual void OnGetUserInfoSuccess(const std::string& key,
                                     const std::string& value) {}
   virtual void OnGetUserInfoKeyNotFound(const std::string& key) {}
   virtual void OnGetUserInfoFailure(const GoogleServiceAuthError& error) {}
 };
 
 #endif  // CHROME_COMMON_NET_GAIA_GAIA_AUTH_CONSUMER_H_