Issue 6350008: Create a new code path to generate sync strings for the new tab page differen...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6350008: Create a new code path to generate sync strings for the new tab page differen... (Closed)

Created:
9 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Create a new code path to generate sync strings for the new tab page different from those used on the settings' page. This will allow us to show on the settings page the current sync status as well as a message regarding passwords. BUG=69622 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72171

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -8 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_page_sync_handler.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_ui_util.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.cc	View	3 chunks	+52 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages