Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 6340: If an allocation is so huge that we cannot code the size needed in the failur... (Closed)

Created:
12 years, 2 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

If an allocation is so huge that we cannot code the size needed in the failure object then we just return an out of memory failure object (instead of a retry after GC failure object). Not all places that checked for retry-after-GC were able to handle an immediate out of memory failure. This fixes http://code.google.com/p/v8/issues/detail?id=70 Committed: http://code.google.com/p/v8/source/detail?r=477

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -22 lines) Patch
M src/builtins.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M src/factory.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-inl.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/jsregexp.cc View 1 chunk +16 lines, -12 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Erik Corry
12 years, 2 months ago (2008-10-08 11:07:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698