src/factory.cc - Issue 6340: If an allocation is so huge that we cannot code the size needed in the failur...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 6340: If an allocation is so huge that we cannot code the size needed in the failur... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 12 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

===================================================================

--- src/factory.cc (revision 469)

+++ src/factory.cc (working copy)

@@ -467,10 +467,12 @@

GC_GREEDY_CHECK();

CallbacksDescriptor desc(*key, *value, attributes);

Object* obj = array->CopyInsert(&desc, REMOVE_TRANSITIONS);

- if (obj->IsRetryAfterGC()) {

- CALL_GC(obj);

- CallbacksDescriptor desc(*key, *value, attributes);

- obj = array->CopyInsert(&desc, REMOVE_TRANSITIONS);

+ if (obj->IsFailure()) {

+ if (obj->IsRetryAfterGC()) {

+ CALL_GC(obj);

+ CallbacksDescriptor desc(*key, *value, attributes);

+ obj = array->CopyInsert(&desc, REMOVE_TRANSITIONS);

+ }

if (obj->IsFailure()) {

// TODO(1181417): Fix this.

V8::FatalProcessOutOfMemory("CopyAppendProxyDescriptor");

« no previous file with comments | « src/builtins.cc ('k') | src/handles.cc » ('j') | no next file with comments »