Issue 6334111: Slight modification to a previously-LGTM'd CL, to work with ebuild changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6334111: Slight modification to a previously-LGTM'd CL, to work with ebuild changes. (Closed)

Created:
9 years, 10 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Slight modification to a previously-LGTM'd CL, to work with ebuild changes. This replaces http://codereview.chromium.org/6307007. The only difference is the Makefile. The vboot_reference ebuild has been changed so that we only attempt to build bmpblk_utility on the host. Change-Id: I4902703baba155e0d2d7646d19b233aa695c282f BUG=chromium-os:11017, chromium-os:10599 TEST=none No test needed. If buildbot is green, it's verified. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d55085d

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+794 lines, -1 line)			Patch
A	firmware/include/bmpblk_header.h	View	1 2 3	1 chunk	+123 lines, -0 lines	0 comments	Download
M	firmware/version.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utility/Makefile	View		2 chunks	+7 lines, -0 lines	0 comments	Download
A	utility/bmpblk_utility.cc	View	1	1 chunk	+551 lines, -0 lines	0 comments	Download
A	utility/include/bmpblk_utility.h	View		1 chunk	+112 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

LGTM