Implement bmpblk_utility tool that creates bmp block from image files.

This change define the data structure of bmp block and implements the create more of bmpblk_utility. It reads a YAML config file, parse the informations, and creates bmpblock file as output.

The list mode and extract mode will be implemented later.

Change-Id: I2b34b323814b1d6b0a369b0e4b2bfa7cf960ff4a

BUG=chromium-os:11017
TEST=build and run, use bvi to check its output.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=95b0ae0

[Hung-Te, 2011-01-21 07:45:41]

http://codereview.chromium.org/6307007/diff/7001/firmware/include/bmpblk_head...
File firmware/include/bmpblk_header.h (right):

http://codereview.chromium.org/6307007/diff/7001/firmware/include/bmpblk_head...
firmware/include/bmpblk_header.h:65: uint32_t number_of_screenlayouts;  /*
Number of screen layouts */
adding "in each localization"  in comments?

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc
File utility/bmpblk_utility.cc (right):

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:310: #define BMP_WIDTH_OFFSET 18
please move this to file beginning, and comment how this is calculated?

Maybe even better to put some asserts to verify that the content is valid, and
offset is appropriate.

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:316: #define BMP_HEIGHT_OFFSET 22
Please check comments for BMP_WIDTH_OFFSET

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:357: memset(&config_.header, '\0',
BMPBLOCK_SIGNATURE_SIZE);
Is this SIGNATURE SIZE, or header size?

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:361: config_.header.number_of_screenlayouts =
config_.localizations[0].size();
should we make some assert to check that each _localizations has same size()?

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:491: while ((opt = getopt_long(argc, argv, "clx:C:",
longopts, &longindex)) >= 0) {
'x:' or 'x'? looks like you don't have arg for -x...

[Tom Wai-Hong Tam, 2011-01-21 08:32:09]

http://codereview.chromium.org/6307007/diff/7001/firmware/include/bmpblk_head...
File firmware/include/bmpblk_header.h (right):

http://codereview.chromium.org/6307007/diff/7001/firmware/include/bmpblk_head...
firmware/include/bmpblk_header.h:65: uint32_t number_of_screenlayouts;  /*
Number of screen layouts */
Done.

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc
File utility/bmpblk_utility.cc (right):

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:310: #define BMP_WIDTH_OFFSET 18
Done.

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:316: #define BMP_HEIGHT_OFFSET 22
Done.

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:357: memset(&config_.header, '\0',
BMPBLOCK_SIGNATURE_SIZE);
It's header size. Fixed it.

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:361: config_.header.number_of_screenlayouts =
config_.localizations[0].size();
Done.

http://codereview.chromium.org/6307007/diff/7001/utility/bmpblk_utility.cc#ne...
utility/bmpblk_utility.cc:491: while ((opt = getopt_long(argc, argv, "clx:C:",
longopts, &longindex)) >= 0) {
Yes, fixed it.

[Hung-Te, 2011-01-21 08:37:13]

LGTM - but please also wait for Bill's approval to confirm if such
implementation matches his design. Thanks!

[Bill Richardson, 2011-01-21 18:39:50]

LGTM. Very nice!

[Tom Wai-Hong Tam, 2011-01-28 04:00:32]

This change has been reverted. Since it lacks of libyaml in the buildbot. I
discussed with Hung-Te and Che-Liang. Seems that there is no better solution
except waiting for libyaml in the buildbot. So let's wait and I will submit this
change one week later.

[Hung-Te, 2011-01-28 06:32:16]

Actually adding libyaml in the dependency of vboot reference seem to be the
correct solution; however since we don't want libyaml in non-host environments,
I guess currently we can only wait for the builtbot to cycle.

[Bill Richardson, 2011-01-28 19:23:19]

While we're waiting for the build to stabilize, we should tweak the allowed
compression modes. I've put some notes in the BMPBLOCK document.

https://docs.google.com/a/google.com/document/d/1pkA34BOpBm2OlPln4ltE3YrFuSvR...

http://codereview.chromium.org/6307007/diff/28001/firmware/include/bmpblk_hea...
File firmware/include/bmpblk_header.h (right):

http://codereview.chromium.org/6307007/diff/28001/firmware/include/bmpblk_hea...
firmware/include/bmpblk_header.h:119: COMPRESS_LZMA,
"LZMA" isn't specific enough to identify the compression scheme supported by the
x86 BIOS. This needs a little tweaking.