Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2544)

Unified Diff: chrome/browser/renderer_host/resource_dispatcher_host.cc

Issue 6328010: Fix Task Manager to correctly display network usage of plug-in processes. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Set origin PID consistently, and only set it for plugin requests. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/resource_dispatcher_host.cc
diff --git a/chrome/browser/renderer_host/resource_dispatcher_host.cc b/chrome/browser/renderer_host/resource_dispatcher_host.cc
index 726242a4c915c52aa2ee3dd1bb4b5c303cf33606..73f54b69d9bb59b8e16dc03411119eedfeccb263 100644
--- a/chrome/browser/renderer_host/resource_dispatcher_host.cc
+++ b/chrome/browser/renderer_host/resource_dispatcher_host.cc
@@ -196,13 +196,13 @@ std::vector<int> GetAllNetErrorCodes() {
}
#if defined(OS_WIN)
-#pragma warning (disable: 4748)
-#pragma optimize( "", off )
+#pragma warning(disable: 4748)
+#pragma optimize("", off)
#endif
#if defined(OS_WIN)
-#pragma optimize( "", on )
-#pragma warning (default: 4748)
+#pragma optimize("", on)
+#pragma warning(default: 4748)
#endif
} // namespace
@@ -518,8 +518,8 @@ void ResourceDispatcherHost::BeginRequest(
ApplyExtensionLocalizationFilter(request_data.url, request_data.resource_type,
extra_info);
SetRequestInfo(request, extra_info); // Request takes ownership.
- chrome_browser_net::SetOriginProcessUniqueIDForRequest(
- request_data.origin_child_id, request);
+ chrome_browser_net::SetOriginProcessIDForRequest(
+ request_data.origin_pid, request);
if (request->url().SchemeIs(chrome::kBlobScheme) && context) {
// Hang on to a reference to ensure the blob is not released prior
@@ -733,7 +733,6 @@ void ResourceDispatcherHost::BeginDownload(
ResourceDispatcherHostRequestInfo* extra_info =
CreateRequestInfoForBrowserRequest(handler, child_id, route_id, true);
SetRequestInfo(request, extra_info); // Request takes ownership.
- chrome_browser_net::SetOriginProcessUniqueIDForRequest(child_id, request);
jam 2011/02/03 22:58:07 why take this out?
BeginRequestInternal(request);
}
@@ -781,7 +780,6 @@ void ResourceDispatcherHost::BeginSaveFile(
ResourceDispatcherHostRequestInfo* extra_info =
CreateRequestInfoForBrowserRequest(handler, child_id, route_id, false);
SetRequestInfo(request, extra_info); // Request takes ownership.
- chrome_browser_net::SetOriginProcessUniqueIDForRequest(child_id, request);
jam 2011/02/03 22:58:07 ditto
BeginRequestInternal(request);
}

Powered by Google App Engine
This is Rietveld 408576698