Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Unified Diff: chrome/browser/net/url_request_tracking.h

Issue 6328010: Fix Task Manager to correctly display network usage of plug-in processes. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Set origin PID consistently, and only set it for plugin requests. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/url_request_tracking.h
diff --git a/chrome/browser/net/url_request_tracking.h b/chrome/browser/net/url_request_tracking.h
index 0e7a715634fee952e3f2f2d4ef77a93117dd0579..07bd401073998412b53f5f61648db5f5c5df7b5b 100644
--- a/chrome/browser/net/url_request_tracking.h
+++ b/chrome/browser/net/url_request_tracking.h
@@ -19,19 +19,15 @@ namespace chrome_browser_net {
// network view in the task manager.
//
// If you make a request on behalf of a child process, please call this
-// function. The default value will be -1 which will be interprepreted as
-// originating from the browser itself.
-//
-// The ID is the child process' unique ID (not a PID) of the process originating
-// the request. This is normally the renderer corresponding to the load. If a
-// plugin process does a request through a renderer process this will be the
-// plugin (the originator of the request).
-void SetOriginProcessUniqueIDForRequest(int id, net::URLRequest* request);
+// function to store its process ID (NOT its browser-assigned unique ID!).
+// The default value will be 0 which should be
+// interpreted as originating from the Browser process.
jam 2011/02/03 22:58:07 I thought it's not also set for renderer processes
+void SetOriginProcessIDForRequest(int id, net::URLRequest* request);
jam 2011/02/03 22:58:07 nit: can we use PID instead of ProcessID to furthe
-// Returns the child process' unique ID that has been previously set by
-// SetOriginProcessUniqueIDForRequest. If no ID has been set, the return
-// value is -1. We use this to identify requests made by the browser process.
-int GetOriginProcessUniqueIDForRequest(const net::URLRequest* request);
+// Returns the process ID of the request's originator, previously stored with
+// SetOriginProcessIDForRequest, or 0 if no process ID
+// has been set.
+int GetOriginProcessIDForRequest(const net::URLRequest* request);
} // namespace chrome_browser_net
« no previous file with comments | « no previous file | chrome/browser/net/url_request_tracking.cc » ('j') | chrome/browser/renderer_host/resource_dispatcher_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698