Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1970)

Unified Diff: chrome/browser/net/url_request_tracking.cc

Issue 6328010: Fix Task Manager to correctly display network usage of plug-in processes. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Set origin PID consistently, and only set it for plugin requests. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/url_request_tracking.cc
diff --git a/chrome/browser/net/url_request_tracking.cc b/chrome/browser/net/url_request_tracking.cc
index a931856ad8fb57dc2eb4659749607a02620f5553..2b838af57e57b431a492ff00b3f187d18b4df403 100644
--- a/chrome/browser/net/url_request_tracking.cc
+++ b/chrome/browser/net/url_request_tracking.cc
@@ -11,37 +11,37 @@ namespace {
// The value is not important, this address is used as the unique key for the
// PID.
-const void* kOriginProcessUniqueIDKey = 0;
+const void* kOriginProcessIDKey = 0;
-class UniqueIDData : public net::URLRequest::UserData {
+class ProcessIDData : public net::URLRequest::UserData {
public:
- explicit UniqueIDData(int id) : id_(id) {}
- virtual ~UniqueIDData() {}
+ explicit ProcessIDData(int pid) : pid_(pid) {}
+ virtual ~ProcessIDData() {}
- int id() const { return id_; }
- void set_id(int id) { id_ = id; }
+ int pid() const { return pid_; }
+ void set_pid(int pid) { pid_ = pid; }
private:
- int id_;
+ int pid_;
- DISALLOW_COPY_AND_ASSIGN(UniqueIDData);
+ DISALLOW_COPY_AND_ASSIGN(ProcessIDData);
};
} // namespace
namespace chrome_browser_net {
-void SetOriginProcessUniqueIDForRequest(int id, net::URLRequest* request) {
+void SetOriginProcessIDForRequest(int pid, net::URLRequest* request) {
// The request will take ownership.
- request->SetUserData(&kOriginProcessUniqueIDKey, new UniqueIDData(id));
+ request->SetUserData(&kOriginProcessIDKey, new ProcessIDData(pid));
}
-int GetOriginProcessUniqueIDForRequest(const net::URLRequest* request) {
- const UniqueIDData* data = static_cast<const UniqueIDData*>(
- request->GetUserData(&kOriginProcessUniqueIDKey));
+int GetOriginProcessIDForRequest(const net::URLRequest* request) {
+ const ProcessIDData* data = static_cast<const ProcessIDData*>(
+ request->GetUserData(&kOriginProcessIDKey));
if (!data)
- return -1;
- return data->id();
+ return 0;
+ return data->pid();
}
} // namespace chrome_browser_net

Powered by Google App Engine
This is Rietveld 408576698