Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker.cc

Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test for covariant return types Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/sandboxed_extension_unpacker.cc
diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker.cc b/chrome/browser/extensions/sandboxed_extension_unpacker.cc
index 9d7e45b7c1c98cfc20b7b70053c4ee6d0ba0e70b..6ae14a236e75abce1e502b383ba49c3c43ecc414 100644
--- a/chrome/browser/extensions/sandboxed_extension_unpacker.cc
+++ b/chrome/browser/extensions/sandboxed_extension_unpacker.cc
@@ -325,8 +325,7 @@ DictionaryValue* SandboxedExtensionUnpacker::RewriteManifestFile(
// Add the public key extracted earlier to the parsed manifest and overwrite
// the original manifest. We do this to ensure the manifest doesn't contain an
// exploitable bug that could be used to compromise the browser.
- scoped_ptr<DictionaryValue> final_manifest(
- static_cast<DictionaryValue*>(manifest.DeepCopy()));
+ scoped_ptr<DictionaryValue> final_manifest(manifest.DeepCopy());
final_manifest->SetString(extension_manifest_keys::kPublicKey, public_key_);
std::string manifest_json;
« no previous file with comments | « chrome/browser/extensions/external_pref_extension_loader.cc ('k') | chrome/browser/importer/importer_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698