chrome/browser/extensions/external_pref_extension_loader.cc - Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_pref_extension_loader.cc

Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add test for covariant return types Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/external_pref_extension_loader.cc

diff --git a/chrome/browser/extensions/external_pref_extension_loader.cc b/chrome/browser/extensions/external_pref_extension_loader.cc

index b1b5d473f4f59350f866a1240acf38fd70774f9e..791005ca246f6aabcfe03a6d794681560bd21f0f 100644

--- a/chrome/browser/extensions/external_pref_extension_loader.cc

+++ b/chrome/browser/extensions/external_pref_extension_loader.cc

@@ -76,7 +76,6 @@ ExternalTestingExtensionLoader::ExternalTestingExtensionLoader(

void ExternalTestingExtensionLoader::StartLoading() {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- prefs_.reset(

- static_cast<DictionaryValue*>(testing_prefs_->DeepCopy()));

+ prefs_.reset(testing_prefs_->DeepCopy());

LoadFinished();

}

« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/extensions/sandboxed_extension_unpacker.cc » ('j') | no next file with comments »