chrome/browser/importer/importer_bridge.cc - Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/importer_bridge.cc

Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add test for covariant return types Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/sandboxed_extension_unpacker.cc ('k') | chrome/browser/policy/device_management_policy_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/importer_bridge.cc

diff --git a/chrome/browser/importer/importer_bridge.cc b/chrome/browser/importer/importer_bridge.cc

index 588e365a7d0418a0431cbeb10776146bd91e246f..b7142182af5335ae57e9a2bdcedc72a4c1ec1e38 100644

--- a/chrome/browser/importer/importer_bridge.cc

+++ b/chrome/browser/importer/importer_bridge.cc

@@ -128,8 +128,7 @@ ExternalProcessImporterBridge::ExternalProcessImporterBridge(

: profile_import_thread_(profile_import_thread) {

// Bridge needs to make its own copy because OS 10.6 autoreleases the

// localized_strings value that is passed in (see http://crbug.com/46003 ).

- localized_strings_.reset(

- static_cast<DictionaryValue*>(localized_strings.DeepCopy()));

+ localized_strings_.reset(localized_strings.DeepCopy());

}

void ExternalProcessImporterBridge::AddBookmarkEntries(