chrome/browser/extensions/extension_prefs.cc - Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add test for covariant return types Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_function.cc ('k') | chrome/browser/extensions/external_pref_extension_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_prefs.cc

diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc

index da1bd259c0c37a5a8384b661f5b1167f10c5d75c..3f6bb88dfc3597c1eccd1079af12ee52dd871425 100644

--- a/chrome/browser/extensions/extension_prefs.cc

+++ b/chrome/browser/extensions/extension_prefs.cc

@@ -239,8 +239,7 @@ void ExtensionPrefs::MakePathsAbsolute(DictionaryValue* dict) {

DictionaryValue* ExtensionPrefs::CopyCurrentExtensions() {

const DictionaryValue* extensions = prefs_->GetDictionary(kExtensionsPref);

if (extensions) {

- DictionaryValue* copy =

- static_cast<DictionaryValue*>(extensions->DeepCopy());

+ DictionaryValue* copy = extensions->DeepCopy();

MakePathsAbsolute(copy);

return copy;

}

« no previous file with comments | « chrome/browser/extensions/extension_function.cc ('k') | chrome/browser/extensions/external_pref_extension_loader.cc » ('j') | no next file with comments »