chrome/browser/extensions/extension_function.cc - Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function.cc

Issue 6324004: Made return types of various Value::DeepCopy() implementations more specific (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add test for covariant return types Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_function.cc

diff --git a/chrome/browser/extensions/extension_function.cc b/chrome/browser/extensions/extension_function.cc

index 054c882b046c414e93acaf88e766da3eb66e27f5..9f0d065cd1d9d128ebbf7455e3aebf175be1d347 100644

--- a/chrome/browser/extensions/extension_function.cc

+++ b/chrome/browser/extensions/extension_function.cc

@@ -40,7 +40,7 @@ AsyncExtensionFunction::~AsyncExtensionFunction() {

void AsyncExtensionFunction::SetArgs(const ListValue* args) {

DCHECK(!args_.get()); // Should only be called once.

- args_.reset(static_cast<ListValue*>(args->DeepCopy()));

+ args_.reset(args->DeepCopy());

}

const std::string AsyncExtensionFunction::GetResult() {

« no previous file with comments | « ceee/ie/broker/window_api_module.cc ('k') | chrome/browser/extensions/extension_prefs.cc » ('j') | no next file with comments »