Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6322001: Remove wstring from TemplateURL and friends.... (Closed)

Created:
9 years, 11 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, evanm
CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, dhollowa
Visibility:
Public.

Description

Remove wstring from TemplateURL and friends. BUG=23581 TEST=no visible changes; all tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71485

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -658 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 11 chunks +27 lines, -21 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider_unittest.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 12 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/dom_ui/options/browser_options_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/options/search_engine_manager_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_omnibox_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/edit_search_engine_dialog.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/gtk/first_run_dialog.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/keyword_editor_view_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/gtk/options/general_page_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox2_importer.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/importer_messages.h View 1 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/edit_search_engine_controller.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/search_engines/keyword_editor_controller.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/search_engines/keyword_editor_controller_unittest.cc View 6 chunks +15 lines, -11 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/search_engines/search_terms_data.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/search_terms_data.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/search_engines/template_url.h View 10 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 15 chunks +39 lines, -41 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 15 chunks +24 lines, -22 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.h View 9 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 17 chunks +43 lines, -42 lines 0 comments Download
M chrome/browser/search_engines/template_url_model_test_util.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_model_test_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/search_engines/template_url_model_unittest.cc View 39 chunks +135 lines, -120 lines 0 comments Download
M chrome/browser/search_engines/template_url_parser.cc View 11 chunks +15 lines, -20 lines 0 comments Download
M chrome/browser/search_engines/template_url_parser_unittest.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_table_model.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/search_engines/template_url_unittest.cc View 24 chunks +65 lines, -62 lines 0 comments Download
M chrome/browser/search_engines/util.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/edit_search_engine_cocoa_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/edit_search_engine_cocoa_controller_unittest.mm View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/keyword_editor_cocoa_controller_unittest.mm View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 5 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/search_engine_dialog_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/search_engine_list_model.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/search_engine_list_model_unittest.mm View 5 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/ui/omnibox/location_bar_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/selected_keyword_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_database.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/webdata/web_database_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M net/base/escape.h View 2 chunks +3 lines, -3 lines 0 comments Download
net/base/escape.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/escape_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
9 years, 11 months ago (2011-01-13 20:31:27 UTC) #1
evanm
LGTM, though I admit I skimmed I had a dream this morning that we could ...
9 years, 11 months ago (2011-01-13 20:45:33 UTC) #2
Avi (use Gerrit)
9 years, 11 months ago (2011-01-13 21:07:04 UTC) #3 
On 2011/01/13 20:45:33, evanm wrote:
> LGTM, though I admit I skimmed
> 
> I had a dream this morning that we could just regex wstring to string16 in
> views/ and deal with it once and for all

I wish. Something about views needed to subclass...

Powered by Google App Engine
This is Rietveld 408576698