Remove wstring from TemplateURL and friends....

chrome/browser/search_engines/template_url_unittest.cc

-// Copyright (c) 2006-2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/rlz/rlz.h"
 #include "chrome/browser/search_engines/search_terms_data.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // Simple implementation of SearchTermsData.
 class TestSearchTermsData : public SearchTermsData {
  public:
   explicit TestSearchTermsData(const char* google_base_url)
       : google_base_url_(google_base_url)  {
   }
 
   virtual std::string GoogleBaseURLValue() const {
     return google_base_url_;
   }
 
   virtual std::string GetApplicationLocale() const {
     return "yy";
   }
 
 #if defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD)
   // Returns the value for the Chrome Omnibox rlz.
-  virtual std::wstring GetRlzParameterValue() const {
-    return L"";
+  virtual string16 GetRlzParameterValue() const {
+    return string16();
   }
 #endif
 
  private:
   std::string google_base_url_;
 
   DISALLOW_COPY_AND_ASSIGN(TestSearchTermsData);
 };
 
 class TemplateURLTest : public testing::Test {
@@ skipping 18 matching lines @@
 }
 
 TEST_F(TemplateURLTest, TestValidWithComplete) {
   TemplateURLRef ref("{searchTerms}", 0, 0);
   ASSERT_TRUE(ref.IsValid());
 }
 
 TEST_F(TemplateURLTest, URLRefTestSearchTerms) {
   struct SearchTermsCase {
     const char* url;
-    const wchar_t* terms;
+    const string16 terms;
     const char* output;
   } search_term_cases[] = {
-    { "http://foo{searchTerms}", L"sea rch/bar", "http://foosea%20rch/bar" },
-    { "http://foo{searchTerms}?boo=abc", L"sea rch/bar",
+    { "http://foo{searchTerms}", ASCIIToUTF16("sea rch/bar"),
+      "http://foosea%20rch/bar" },
+    { "http://foo{searchTerms}?boo=abc", ASCIIToUTF16("sea rch/bar"),
       "http://foosea%20rch/bar?boo=abc" },
-    { "http://foo/?boo={searchTerms}", L"sea rch/bar",
+    { "http://foo/?boo={searchTerms}", ASCIIToUTF16("sea rch/bar"),
       "http://foo/?boo=sea+rch%2Fbar" },
-    { "http://en.wikipedia.org/{searchTerms}", L"wiki/?",
+    { "http://en.wikipedia.org/{searchTerms}", ASCIIToUTF16("wiki/?"),
       "http://en.wikipedia.org/wiki/%3F" }
   };
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(search_term_cases); ++i) {
     const SearchTermsCase& value = search_term_cases[i];
     TemplateURL t_url;
     TemplateURLRef ref(value.url, 0, 0);
     ASSERT_TRUE(ref.IsValid());
 
     ASSERT_TRUE(ref.SupportsReplacement());
     GURL result = GURL(ref.ReplaceSearchTerms(t_url, value.terms,
-        TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+        TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
     ASSERT_TRUE(result.is_valid());
     ASSERT_EQ(value.output, result.spec());
   }
 }
 
 TEST_F(TemplateURLTest, URLRefTestCount) {
   TemplateURL t_url;
   TemplateURLRef ref("http://foo{searchTerms}{count?}", 0, 0);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
-  GURL result = GURL(ref.ReplaceSearchTerms(t_url, L"X",
-      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+  GURL result = GURL(ref.ReplaceSearchTerms(t_url, ASCIIToUTF16("X"),
+      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
   ASSERT_TRUE(result.is_valid());
   ASSERT_EQ("http://foox/", result.spec());
 }
 
 TEST_F(TemplateURLTest, URLRefTestCount2) {
   TemplateURL t_url;
   TemplateURLRef ref("http://foo{searchTerms}{count}", 0, 0);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
-  GURL result = GURL(ref.ReplaceSearchTerms(t_url, L"X",
-      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+  GURL result = GURL(ref.ReplaceSearchTerms(t_url, ASCIIToUTF16("X"),
+      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
   ASSERT_TRUE(result.is_valid());
   ASSERT_EQ("http://foox10/", result.spec());
 }
 
 TEST_F(TemplateURLTest, URLRefTestIndices) {
   TemplateURL t_url;
   TemplateURLRef ref("http://foo{searchTerms}x{startIndex?}y{startPage?}",
                      1, 2);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
-  GURL result = GURL(ref.ReplaceSearchTerms(t_url, L"X",
-      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+  GURL result = GURL(ref.ReplaceSearchTerms(t_url, ASCIIToUTF16("X"),
+      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
   ASSERT_TRUE(result.is_valid());
   ASSERT_EQ("http://fooxxy/", result.spec());
 }
 
 TEST_F(TemplateURLTest, URLRefTestIndices2) {
   TemplateURL t_url;
   TemplateURLRef ref("http://foo{searchTerms}x{startIndex}y{startPage}", 1, 2);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
-  GURL result = GURL(ref.ReplaceSearchTerms(t_url, L"X",
-      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+  GURL result = GURL(ref.ReplaceSearchTerms(t_url, ASCIIToUTF16("X"),
+      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
   ASSERT_TRUE(result.is_valid());
   ASSERT_EQ("http://fooxx1y2/", result.spec());
 }
 
 TEST_F(TemplateURLTest, URLRefTestEncoding) {
   TemplateURL t_url;
   TemplateURLRef ref(
       "http://foo{searchTerms}x{inputEncoding?}y{outputEncoding?}a", 1, 2);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
-  GURL result = GURL(ref.ReplaceSearchTerms(t_url, L"X",
-      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+  GURL result = GURL(ref.ReplaceSearchTerms(t_url, ASCIIToUTF16("X"),
+      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
   ASSERT_TRUE(result.is_valid());
   ASSERT_EQ("http://fooxxutf-8ya/", result.spec());
 }
 
 TEST_F(TemplateURLTest, InputEncodingBeforeSearchTerm) {
   TemplateURL t_url;
   TemplateURLRef ref(
       "http://foox{inputEncoding?}a{searchTerms}y{outputEncoding?}b", 1, 2);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
-  GURL result = GURL(ref.ReplaceSearchTerms(t_url, L"X",
-      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+  GURL result = GURL(ref.ReplaceSearchTerms(t_url, ASCIIToUTF16("X"),
+      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
   ASSERT_TRUE(result.is_valid());
   ASSERT_EQ("http://fooxutf-8axyb/", result.spec());
 }
 
 TEST_F(TemplateURLTest, URLRefTestEncoding2) {
   TemplateURL t_url;
   TemplateURLRef ref(
       "http://foo{searchTerms}x{inputEncoding}y{outputEncoding}a", 1, 2);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
-  GURL result = GURL(ref.ReplaceSearchTerms(t_url, L"X",
-      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+  GURL result = GURL(ref.ReplaceSearchTerms(t_url, ASCIIToUTF16("X"),
+      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
   ASSERT_TRUE(result.is_valid());
   ASSERT_EQ("http://fooxxutf-8yutf-8a/", result.spec());
 }
 
 TEST_F(TemplateURLTest, URLRefTestSearchTermsUsingTermsData) {
   struct SearchTermsCase {
     const char* url;
-    const wchar_t* terms;
+    const string16 terms;
     const char* output;
   } search_term_cases[] = {
-    { "{google:baseURL}{language}{searchTerms}", L"",
+    { "{google:baseURL}{language}{searchTerms}", string16(),
       "http://example.com/e/yy" },
-    { "{google:baseSuggestURL}{searchTerms}", L"",
+    { "{google:baseSuggestURL}{searchTerms}", string16(),
       "http://clients1.example.com/complete/" }
   };
 
   TestSearchTermsData search_terms_data("http://example.com/e/");
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(search_term_cases); ++i) {
     const SearchTermsCase& value = search_term_cases[i];
     TemplateURL t_url;
     TemplateURLRef ref(value.url, 0, 0);
     ASSERT_TRUE(ref.IsValid());
 
     ASSERT_TRUE(ref.SupportsReplacement());
     GURL result = GURL(ref.ReplaceSearchTermsUsingTermsData(
         t_url, value.terms,
-        TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring(),
+        TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16(),
         search_terms_data));
     ASSERT_TRUE(result.is_valid());
     ASSERT_EQ(value.output, result.spec());
   }
 }
 
 TEST_F(TemplateURLTest, URLRefTermToWide) {
   struct ToWideCase {
     const char* encoded_search_term;
-    const wchar_t* expected_decoded_term;
+    const string16 expected_decoded_term;
   } to_wide_cases[] = {
-    {"hello+world", L"hello world"},
+    {"hello+world", ASCIIToUTF16("hello world")},
     // Test some big-5 input.
-    {"%a7A%A6%6e+to+you", L"\x4f60\x597d to you"},
+    {"%a7A%A6%6e+to+you", WideToUTF16(L"\x4f60\x597d to you")},
     // Test some UTF-8 input. We should fall back to this when the encoding
     // doesn't look like big-5. We have a '5' in the middle, which is an invalid
     // Big-5 trailing byte.
-    {"%e4%bd%a05%e5%a5%bd+to+you", L"\x4f60\x35\x597d to you"},
+    {"%e4%bd%a05%e5%a5%bd+to+you", WideToUTF16(L"\x4f60\x35\x597d to you")},
     // Undecodable input should stay escaped.
-    {"%91%01+abcd", L"%91%01 abcd"},
+    {"%91%01+abcd", WideToUTF16(L"%91%01 abcd")},
     // Make sure we convert %2B to +.
-    {"C%2B%2B", L"C++"},
+    {"C%2B%2B", ASCIIToUTF16("C++")},
     // C%2B is escaped as C%252B, make sure we unescape it properly.
-    {"C%252B", L"C%2B"},
+    {"C%252B", ASCIIToUTF16("C%2B")},
   };
 
   TemplateURL t_url;
 
   // Set one input encoding: big-5. This is so we can test fallback to UTF-8.
   std::vector<std::string> encodings;
   encodings.push_back("big-5");
   t_url.set_input_encodings(encodings);
 
   TemplateURLRef ref("http://foo?q={searchTerms}", 1, 2);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(to_wide_cases); i++) {
-    std::wstring result = ref.SearchTermToWide(t_url,
+    string16 result = ref.SearchTermToString16(t_url,
         to_wide_cases[i].encoded_search_term);
 
-    EXPECT_EQ(std::wstring(to_wide_cases[i].expected_decoded_term), result);
+    EXPECT_EQ(to_wide_cases[i].expected_decoded_term, result);
   }
 }
 
 TEST_F(TemplateURLTest, SetFavIcon) {
   TemplateURL url;
   GURL favicon_url("http://favicon.url");
   url.SetFavIconURL(favicon_url);
   ASSERT_EQ(1U, url.image_refs().size());
   ASSERT_TRUE(favicon_url == url.GetFavIconURL());
 
   GURL favicon_url2("http://favicon2.url");
   url.SetFavIconURL(favicon_url2);
   ASSERT_EQ(1U, url.image_refs().size());
   ASSERT_TRUE(favicon_url2 == url.GetFavIconURL());
 }
 
 TEST_F(TemplateURLTest, DisplayURLToURLRef) {
   struct TestData {
     const std::string url;
-    const std::wstring expected_result;
+    const string16 expected_result;
   } data[] = {
     { "http://foo{searchTerms}x{inputEncoding}y{outputEncoding}a",
-      L"http://foo%sx{inputEncoding}y{outputEncoding}a" },
+      ASCIIToUTF16("http://foo%sx{inputEncoding}y{outputEncoding}a") },
     { "http://X",
-      L"http://X" },
+      ASCIIToUTF16("http://X") },
     { "http://foo{searchTerms",
-      L"http://foo{searchTerms" },
+      ASCIIToUTF16("http://foo{searchTerms") },
     { "http://foo{searchTerms}{language}",
-      L"http://foo%s{language}" },
+      ASCIIToUTF16("http://foo%s{language}") },
   };
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i) {
     TemplateURLRef ref(data[i].url, 1, 2);
     EXPECT_EQ(data[i].expected_result, ref.DisplayURL());
     EXPECT_EQ(data[i].url,
               TemplateURLRef::DisplayURLToURLRef(ref.DisplayURL()));
   }
 }
 
 TEST_F(TemplateURLTest, ReplaceSearchTerms) {
@@ skipping 28 matching lines @@
   };
   TemplateURL turl;
   turl.add_input_encoding("UTF-8");
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i) {
     TemplateURLRef ref(data[i].url, 1, 2);
     EXPECT_TRUE(ref.IsValid());
     EXPECT_TRUE(ref.SupportsReplacement());
     std::string expected_result = data[i].expected_result;
     ReplaceSubstringsAfterOffset(&expected_result, 0, "{language}",
         g_browser_process->GetApplicationLocale());
-    GURL result = GURL(ref.ReplaceSearchTerms(turl, L"X",
-        TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+    GURL result = GURL(ref.ReplaceSearchTerms(turl, ASCIIToUTF16("X"),
+        TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
     EXPECT_TRUE(result.is_valid());
     EXPECT_EQ(expected_result, result.spec());
   }
 }
 
 
 // Tests replacing search terms in various encodings and making sure the
 // generated URL matches the expected value.
 TEST_F(TemplateURLTest, ReplaceArbitrarySearchTerms) {
   struct TestData {
     const std::string encoding;
-    const std::wstring search_term;
+    const string16 search_term;
     const std::string url;
     const std::string expected_result;
   } data[] = {
-    { "BIG5",  L"\x60BD", "http://foo/?{searchTerms}{inputEncoding}",
+    { "BIG5",  WideToUTF16(L"\x60BD"),
+      "http://foo/?{searchTerms}{inputEncoding}",
       "http://foo/?%B1~BIG5" },
-    { "UTF-8", L"blah",   "http://foo/?{searchTerms}{inputEncoding}",
+    { "UTF-8", ASCIIToUTF16("blah"),
+      "http://foo/?{searchTerms}{inputEncoding}",
       "http://foo/?blahUTF-8" },
   };
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i) {
     TemplateURL turl;
     turl.add_input_encoding(data[i].encoding);
     TemplateURLRef ref(data[i].url, 1, 2);
     GURL result = GURL(ref.ReplaceSearchTerms(turl,
         data[i].search_term, TemplateURLRef::NO_SUGGESTIONS_AVAILABLE,
-        std::wstring()));
+        string16()));
     EXPECT_TRUE(result.is_valid());
     EXPECT_EQ(data[i].expected_result, result.spec());
   }
 }
 
 TEST_F(TemplateURLTest, Suggestions) {
   struct TestData {
     const int accepted_suggestion;
-    const std::wstring original_query_for_suggestion;
+    const string16 original_query_for_suggestion;
     const std::string expected_result;
   } data[] = {
-    { TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring(),
+    { TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16(),
       "http://bar/foo?q=foobar" },
-    { TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, L"foo",
+    { TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, ASCIIToUTF16("foo"),
       "http://bar/foo?q=foobar" },
-    { TemplateURLRef::NO_SUGGESTION_CHOSEN, std::wstring(),
+    { TemplateURLRef::NO_SUGGESTION_CHOSEN, string16(),
       "http://bar/foo?aq=f&q=foobar" },
-    { TemplateURLRef::NO_SUGGESTION_CHOSEN, L"foo",
+    { TemplateURLRef::NO_SUGGESTION_CHOSEN, ASCIIToUTF16("foo"),
       "http://bar/foo?aq=f&q=foobar" },
-    { 0, std::wstring(), "http://bar/foo?aq=0&oq=&q=foobar" },
-    { 1, L"foo", "http://bar/foo?aq=1&oq=foo&q=foobar" },
+    { 0, string16(), "http://bar/foo?aq=0&oq=&q=foobar" },
+    { 1, ASCIIToUTF16("foo"), "http://bar/foo?aq=1&oq=foo&q=foobar" },
   };
   TemplateURL turl;
   turl.add_input_encoding("UTF-8");
   TemplateURLRef ref("http://bar/foo?{google:acceptedSuggestion}"
       "{google:originalQueryForSuggestion}q={searchTerms}", 1, 2);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i) {
-    GURL result = GURL(ref.ReplaceSearchTerms(turl, L"foobar",
+    GURL result = GURL(ref.ReplaceSearchTerms(turl, ASCIIToUTF16("foobar"),
         data[i].accepted_suggestion, data[i].original_query_for_suggestion));
     EXPECT_TRUE(result.is_valid());
     EXPECT_EQ(data[i].expected_result, result.spec());
   }
 }
 
 #if defined(OS_WIN)
 TEST_F(TemplateURLTest, RLZ) {
-  std::wstring rlz_string;
+  string16 rlz_string;
 #if defined(GOOGLE_CHROME_BUILD)
   RLZTracker::GetAccessPointRlz(rlz_lib::CHROME_OMNIBOX, &rlz_string);
 #endif
 
   TemplateURL t_url;
   TemplateURLRef ref("http://bar/?{google:RLZ}{searchTerms}", 1, 2);
   ASSERT_TRUE(ref.IsValid());
   ASSERT_TRUE(ref.SupportsReplacement());
   GURL result(ref.ReplaceSearchTerms(t_url, L"x",
-      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring()));
+      TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
   ASSERT_TRUE(result.is_valid());
   std::string expected_url = "http://bar/?";
   if (!rlz_string.empty()) {
     expected_url += "rlz=" + WideToUTF8(rlz_string) + "&";
   }
   expected_url += "x";
   ASSERT_EQ(expected_url, result.spec());
 }
 #endif
 
@@ skipping 47 matching lines @@
   };
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i)
     CheckSuggestBaseURL(data[i].base_url, data[i].base_suggest_url);
 }
 
 TEST_F(TemplateURLTest, Keyword) {
   TemplateURL t_url;
   t_url.SetURL("http://www.google.com/search", 0, 0);
   EXPECT_FALSE(t_url.autogenerate_keyword());
-  t_url.set_keyword(L"foo");
-  EXPECT_EQ(L"foo", t_url.keyword());
+  t_url.set_keyword(ASCIIToUTF16("foo"));
+  EXPECT_EQ(ASCIIToUTF16("foo"), t_url.keyword());
   t_url.set_autogenerate_keyword(true);
   EXPECT_TRUE(t_url.autogenerate_keyword());
-  EXPECT_EQ(L"google.com", t_url.keyword());
-  t_url.set_keyword(L"foo");
+  EXPECT_EQ(ASCIIToUTF16("google.com"), t_url.keyword());
+  t_url.set_keyword(ASCIIToUTF16("foo"));
   EXPECT_FALSE(t_url.autogenerate_keyword());
-  EXPECT_EQ(L"foo", t_url.keyword());
+  EXPECT_EQ(ASCIIToUTF16("foo"), t_url.keyword());
 }
 
 TEST_F(TemplateURLTest, ParseParameterKnown) {
   std::string parsed_url("{searchTerms}");
   TemplateURLRef url_ref(parsed_url, 0, 0);
   TemplateURLRef::Replacements replacements;
   EXPECT_TRUE(url_ref.ParseParameter(0, 12, &parsed_url, &replacements));
   EXPECT_EQ(std::string(), parsed_url);
   ASSERT_EQ(1U, replacements.size());
   EXPECT_EQ(static_cast<size_t>(0), replacements[0].index);
@@ skipping 51 matching lines @@
 TEST_F(TemplateURLTest, ParseURLNestedParameter) {
   TemplateURLRef url_ref("{%s", 0, 0);
   TemplateURLRef::Replacements replacements;
   bool valid = false;
   EXPECT_EQ("{", url_ref.ParseURL("{{searchTerms}", &replacements, &valid));
   ASSERT_EQ(1U, replacements.size());
   EXPECT_EQ(static_cast<size_t>(1), replacements[0].index);
   EXPECT_EQ(TemplateURLRef::SEARCH_TERMS, replacements[0].type);
   EXPECT_TRUE(valid);
 }