dom-ui settings: enable languages & spell checker settings for all platforms....

chrome/browser/resources/options/language_add_language_overlay.html

Index: chrome/browser/resources/options/language_add_language_overlay.html
===================================================================
--- chrome/browser/resources/options/language_add_language_overlay.html	(revision 71884)
+++ chrome/browser/resources/options/language_add_language_overlay.html	(working copy)
@@ -1,6 +1,24 @@
 <div class="page hidden" id="add-language-overlay-page">
+  <h1 i18n-content="add_language_title"></h1>

[satorux1, 2011/01/21 01:38:46]

Please move this to inside of <if expr="not pp_ifdef('chromeos')">. We are
planning to rework the language selection UI. Until then, it'd be safer to leave
it as-is.

+<if expr="pp_ifdef('chromeos')">
   <ul id="add-language-overlay-language-list">
   </ul>
   <button id="add-language-overlay-cancel-button"
           i18n-content="cancel"></button>
+</if>
+<if expr="not pp_ifdef('chromeos')">

[satorux1, 2011/01/20 10:40:33]

Why cannot we share the same UI? The Chrome OS version lists languages in two
columns. This makes it easy for users to choose a language, than from a list in
<select>. We implemented this way based on feedback from users and UX

[csilv, 2011/01/20 20:09:55]

The two column UI works well on ChromeOS, but on the browser it is problematic. 
This is because the list is populated with Accept Languages, which greatly
outnumbers input methods.  On ChromeOS, there are about 40 items, on the browser
there are 132.  This creates a very large overlay that is too large for even a
big screen.

While I think this solution is acceptable for now (it's essentially the same UI
as used on windows), this is probably worth revisiting for a UI review.  There
are other options such as a scrollable list that might be more friendly.

[satorux1, 2011/01/21 01:38:46]

Thank you for the explanation. Didn't know that we have 132 languages in other
platforms.

I had a chat with ainslie@ about the language selection UI. His idea was that we
should stop showing the language list as overlay, but instead show the list on
the right hand side of the language options page:

http://code.google.com/p/chromium-os/issues/detail?id=10699

I think someone in Tokyo will be doing this.

+  <label>
+    <span i18n-content="add_language_select_label"></span>
+    <select id="add-language-overlay-language-list">
+    </select>

[James Hawkins, 2011/01/20 03:11:08]

Fits on the line above.

[csilv, 2011/01/20 20:09:55]

Done.

+  </label>
+  <div class="action-area">
+    <div class="button-strip">
+      <button id="add-language-overlay-cancel-button" i18n-content="cancel">
+      </button>
+      <button id="add-language-overlay-ok-button" i18n-content="ok">
+      </button>

[James Hawkins, 2011/01/20 03:11:08]

Probably fits on the line above.

[csilv, 2011/01/20 20:09:55]

Done.

+    </div>
+  </div>
+</if>
 </div>