chrome/browser/resources/options/language_add_language_overlay.html - Issue 6296017: dom-ui settings: enable languages & spell checker settings for all platforms....

Side by Side Diff: chrome/browser/resources/options/language_add_language_overlay.html

Issue 6296017: dom-ui settings: enable languages & spell checker settings for all platforms.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: chromeos namespace fix, part 4 Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/dom_ui/options/language_options_handler_unittest.cc ('K') | « chrome/browser/resources/options/advanced_options.js ('k') | chrome/browser/resources/options/language_add_language_overlay.js » ('j') | chrome/browser/resources/options/language_options.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div class="page hidden" id="add-language-overlay-page">	1 <div class="page hidden" id="add-language-overlay-page">

	2 <h1 i18n-content="add_language_title"></h1>
	satorux1 2011/01/21 01:38:46 Please move this to inside of <if expr="not pp_ifd Please move this to inside of <if expr="not pp_ifdef('chromeos')">. We are planning to rework the language selection UI. Until then, it'd be safer to leave it as-is.
	3 <if expr="pp_ifdef('chromeos')">

2 <ul id="add-language-overlay-language-list">	4 <ul id="add-language-overlay-language-list">

3 </ul>	5 </ul>

4 <button id="add-language-overlay-cancel-button"	6 <button id="add-language-overlay-cancel-button"

5 i18n-content="cancel"></button>	7 i18n-content="cancel"></button>

	8 </if>

	9 <if expr="not pp_ifdef('chromeos')">
	satorux1 2011/01/20 10:40:33 Why cannot we share the same UI? The Chrome OS ver Why cannot we share the same UI? The Chrome OS version lists languages in two columns. This makes it easy for users to choose a language, than from a list in <select>. We implemented this way based on feedback from users and UX csilv 2011/01/20 20:09:55 The two column UI works well on ChromeOS, but on t Show quoted text On 2011/01/20 10:40:33, satorux1 wrote: > Why cannot we share the same UI? The Chrome OS version lists languages in two > columns. This makes it easy for users to choose a language, than from a list in > <select>. We implemented this way based on feedback from users and UX The two column UI works well on ChromeOS, but on the browser it is problematic. This is because the list is populated with Accept Languages, which greatly outnumbers input methods. On ChromeOS, there are about 40 items, on the browser there are 132. This creates a very large overlay that is too large for even a big screen. While I think this solution is acceptable for now (it's essentially the same UI as used on windows), this is probably worth revisiting for a UI review. There are other options such as a scrollable list that might be more friendly. satorux1 2011/01/21 01:38:46 Thank you for the explanation. Didn't know that we Show quoted text On 2011/01/20 20:09:55, csilv wrote: > On 2011/01/20 10:40:33, satorux1 wrote: > > Why cannot we share the same UI? The Chrome OS version lists languages in two > > columns. This makes it easy for users to choose a language, than from a list > in > > <select>. We implemented this way based on feedback from users and UX > > The two column UI works well on ChromeOS, but on the browser it is problematic. > This is because the list is populated with Accept Languages, which greatly > outnumbers input methods. On ChromeOS, there are about 40 items, on the browser > there are 132. This creates a very large overlay that is too large for even a > big screen. > > While I think this solution is acceptable for now (it's essentially the same UI > as used on windows), this is probably worth revisiting for a UI review. There > are other options such as a scrollable list that might be more friendly. Thank you for the explanation. Didn't know that we have 132 languages in other platforms. I had a chat with ainslie@ about the language selection UI. His idea was that we should stop showing the language list as overlay, but instead show the list on the right hand side of the language options page: http://code.google.com/p/chromium-os/issues/detail?id=10699 I think someone in Tokyo will be doing this.
	10 <label>

	11 <span i18n-content="add_language_select_label"></span>

	12 <select id="add-language-overlay-language-list">

	13 </select>
	James Hawkins 2011/01/20 03:11:08 Fits on the line above. Fits on the line above. csilv 2011/01/20 20:09:55 Done. Show quoted text On 2011/01/20 03:11:08, James Hawkins wrote: > Fits on the line above. Done.
	14 </label>

	15 <div class="action-area">

	16 <div class="button-strip">

	17 <button id="add-language-overlay-cancel-button" i18n-content="cancel">

	18 </button>

	19 <button id="add-language-overlay-ok-button" i18n-content="ok">

	20 </button>
	James Hawkins 2011/01/20 03:11:08 Probably fits on the line above. Probably fits on the line above. csilv 2011/01/20 20:09:55 Done. Show quoted text On 2011/01/20 03:11:08, James Hawkins wrote: > Probably fits on the line above. Done.
	21 </div>

	22 </div>

	23 </if>

6 </div>	24 </div>

OLD	NEW