Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2490)

Unified Diff: chrome/browser/resources/options/language_add_language_overlay.js

Issue 6296017: dom-ui settings: enable languages & spell checker settings for all platforms.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: chromeos namespace fix, part 4 Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_add_language_overlay.js
===================================================================
--- chrome/browser/resources/options/language_add_language_overlay.js (revision 71884)
+++ chrome/browser/resources/options/language_add_language_overlay.js (working copy)
@@ -39,23 +39,30 @@
};
// Create the language list with which users can add a language.
- // Note that we have about 40 languages.
var addLanguageList = $('add-language-overlay-language-list');
var languageListData = templateData.languageList;
for (var i = 0; i < languageListData.length; i++) {
var language = languageListData[i];
- var button = document.createElement('button');
- button.className = 'link-button';
- button.textContent = language.displayName;
+ var displayText = language.displayName;
// If the native name is different, add it.
if (language.displayName != language.nativeDisplayName) {
- button.textContent += ' - ' + language.nativeDisplayName;
+ displayText += ' - ' + language.nativeDisplayName;
}
- button.languageCode = language.code;
- var li = document.createElement('li');
- li.languageCode = language.code;
- li.appendChild(button);
- addLanguageList.appendChild(li);
+ if (cr.isChromeOS) {
+ var button = document.createElement('button');
+ button.className = 'link-button';
+ button.textContent = displayText;
+ button.languageCode = language.code;
+ var li = document.createElement('li');
+ li.languageCode = language.code;
+ li.appendChild(button);
+ addLanguageList.appendChild(li);
+ } else {
+ var option = document.createElement('option');
+ option.value = language.code;
+ option.textContent = displayText;
+ addLanguageList.appendChild(option);
+ }
}
},
};

Powered by Google App Engine
This is Rietveld 408576698