Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 6268016: Fix GL_CHROMIUM_framebuffer_multisample to accept the correct enums.... (Closed)

Created:
9 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix GL_CHROMIUM_framebuffer_multisample to accept the correct enums. Add support for GL_OES_rgb8_rgba8. Update feature_info unit tests. Tested with the accelerated 2D canvas in WebKit with multisampling turned on. BUG=none TEST=gpu_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 2 chunks +11 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 2 chunks +14 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
9 years, 11 months ago (2011-01-26 01:52:52 UTC) #1
greggman
9 years, 11 months ago (2011-01-26 02:23:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698