Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 6268016: Fix GL_CHROMIUM_framebuffer_multisample to accept the correct enums.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gl_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info_unittest.cc
===================================================================
--- gpu/command_buffer/service/feature_info_unittest.cc (revision 72421)
+++ gpu/command_buffer/service/feature_info_unittest.cc (working copy)
@@ -286,8 +286,10 @@
GL_DRAW_FRAMEBUFFER_EXT));
EXPECT_TRUE(info_.validators()->g_l_state.IsValid(
GL_READ_FRAMEBUFFER_BINDING_EXT));
+ EXPECT_TRUE(info_.validators()->g_l_state.IsValid(
+ GL_MAX_SAMPLES_EXT));
EXPECT_TRUE(info_.validators()->render_buffer_parameter.IsValid(
- GL_MAX_SAMPLES_EXT));
+ GL_RENDERBUFFER_SAMPLES_EXT));
}
TEST_F(FeatureInfoTest, InitializeEXT_texture_filter_anisotropic) {
@@ -395,6 +397,17 @@
EXPECT_TRUE(info_.feature_flags().chromium_webglsl);
}
+TEST_F(FeatureInfoTest, InitializeOES_rgb8_rgba8) {
+ SetupInitExpectations("GL_OES_rgb8_rgba8");
+ info_.Initialize(NULL);
+ EXPECT_THAT(info_.extensions(),
+ HasSubstr("GL_OES_rgb8_rgba8"));
+ EXPECT_TRUE(info_.validators()->render_buffer_format.IsValid(
+ GL_RGB8_OES));
+ EXPECT_TRUE(info_.validators()->render_buffer_format.IsValid(
+ GL_RGBA8_OES));
+}
+
} // namespace gles2
} // namespace gpu
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gl_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698