Issue 6259017: Fix crash in autofill metrics logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6259017: Fix crash in autofill metrics logging. (Closed)

Created:
9 years, 11 months ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Ilya Sherman, Paweł Hajdan Jr., James Hawkins, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crash in autofill metrics logging. Cached forms might not match submitted forms, but the logging code had been assuming that they always do. BUG=70374, 70701 TEST=unit_tests --gtest_filter=AutoFillMetricsTest.SaneMetricsWithCacheMismatch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72453

Patch Set 1 #

Patch Set 2 : Whitespace #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -19 lines)			Patch
M	chrome/browser/autofill/autofill_manager.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager.cc	View	1	5 chunks	+35 lines, -17 lines	0 comments	Download
M	chrome/browser/autofill/autofill_metrics_unittest.cc	View		3 chunks	+96 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages