Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: chrome/browser/autofill/autofill_manager.h

Issue 6259017: Fix crash in autofill metrics logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Whitespace Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index 7116696deb91f35016094b6e260dc73e03f0189a..bad5c3691a41b78303ab4bfde97fdf5d097fd2e1 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -125,6 +125,11 @@ class AutoFillManager : public WebNavigationObserver,
const std::vector<CreditCard*>& credit_cards,
RenderViewHost** host) WARN_UNUSED_RESULT;
+ // Fills |form_structure| cached element corresponding to |form|.
+ // Returns false if the cached element was not found.
+ bool FindCachedForm(const webkit_glue::FormData& form,
+ FormStructure** form_structure) WARN_UNUSED_RESULT;
+
// Fills |form_structure| and |autofill_field| with the cached elements
// corresponding to |form| and |field|. Returns false if the cached elements
// were not found.
@@ -228,6 +233,7 @@ class AutoFillManager : public WebNavigationObserver,
FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, QualityMetrics);
FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest,
NoQualityMetricsForNonAutoFillableForms);
+ FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, SaneMetricsWithCacheMismatch);
FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, QualityMetricsForFailure);
DISALLOW_COPY_AND_ASSIGN(AutoFillManager);
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698