Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/autofill/autofill_manager.h

Issue 6259017: Fix crash in autofill metrics logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Whitespace Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <list> 9 #include <list>
10 #include <string> 10 #include <string>
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 void OnShowAutoFillDialog(); 118 void OnShowAutoFillDialog();
119 void OnDidFillAutoFillFormData(); 119 void OnDidFillAutoFillFormData();
120 void OnDidShowAutoFillSuggestions(); 120 void OnDidShowAutoFillSuggestions();
121 121
122 // Fills |host| with the RenderViewHost for this tab. 122 // Fills |host| with the RenderViewHost for this tab.
123 // Returns false if AutoFill is disabled or if the host is unavailable. 123 // Returns false if AutoFill is disabled or if the host is unavailable.
124 bool GetHost(const std::vector<AutoFillProfile*>& profiles, 124 bool GetHost(const std::vector<AutoFillProfile*>& profiles,
125 const std::vector<CreditCard*>& credit_cards, 125 const std::vector<CreditCard*>& credit_cards,
126 RenderViewHost** host) WARN_UNUSED_RESULT; 126 RenderViewHost** host) WARN_UNUSED_RESULT;
127 127
128 // Fills |form_structure| cached element corresponding to |form|.
129 // Returns false if the cached element was not found.
130 bool FindCachedForm(const webkit_glue::FormData& form,
131 FormStructure** form_structure) WARN_UNUSED_RESULT;
132
128 // Fills |form_structure| and |autofill_field| with the cached elements 133 // Fills |form_structure| and |autofill_field| with the cached elements
129 // corresponding to |form| and |field|. Returns false if the cached elements 134 // corresponding to |form| and |field|. Returns false if the cached elements
130 // were not found. 135 // were not found.
131 bool FindCachedFormAndField( 136 bool FindCachedFormAndField(
132 const webkit_glue::FormData& form, 137 const webkit_glue::FormData& form,
133 const webkit_glue::FormField& field, 138 const webkit_glue::FormField& field,
134 FormStructure** form_structure, 139 FormStructure** form_structure,
135 AutoFillField** autofill_field) WARN_UNUSED_RESULT; 140 AutoFillField** autofill_field) WARN_UNUSED_RESULT;
136 141
137 // Returns a list of values from the stored profiles that match |type| and the 142 // Returns a list of values from the stored profiles that match |type| and the
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillCreditCardForm); 226 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillCreditCardForm);
222 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillAddressForm); 227 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillAddressForm);
223 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillAddressAndCreditCardForm); 228 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillAddressAndCreditCardForm);
224 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillAutoFilledForm); 229 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillAutoFilledForm);
225 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillPhoneNumber); 230 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FillPhoneNumber);
226 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FormChangesRemoveField); 231 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FormChangesRemoveField);
227 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FormChangesAddField); 232 FRIEND_TEST_ALL_PREFIXES(AutoFillManagerTest, FormChangesAddField);
228 FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, QualityMetrics); 233 FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, QualityMetrics);
229 FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, 234 FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest,
230 NoQualityMetricsForNonAutoFillableForms); 235 NoQualityMetricsForNonAutoFillableForms);
236 FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, SaneMetricsWithCacheMismatch);
231 FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, QualityMetricsForFailure); 237 FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, QualityMetricsForFailure);
232 238
233 DISALLOW_COPY_AND_ASSIGN(AutoFillManager); 239 DISALLOW_COPY_AND_ASSIGN(AutoFillManager);
234 }; 240 };
235 241
236 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 242 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698