Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 6250141: Sidebar mini tabs UI (views version)....

Created:
9 years, 10 months ago by Aleksey Shlyapnikov
Modified:
9 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

1) chrome.experimental.sidebar API, sidebar mini tabs UI (views version). Design doc: https://docs.google.com/a/google.com/document/d/1oIPVwVX5-fHZXrWOlu76wAaFOFbx3MTiTVCwfbLRnUo/edit?authkey=CNDi--gD# 2) Switch Sidebar internals from TabContents to TabContentsWrapper. 3) Always show sidebar on the right side of the browser window to be consistent with main page scrollbar position. BUG=51084 TEST=unit_tests::BrowserSidebarTabStripControllerTest.*

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3189 lines, -263 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_sidebar_api.h View 1 2 3 11 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_sidebar_api.cc View 1 2 3 9 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/sidebar/sidebar_browsertest.cc View 1 2 3 5 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/sidebar/sidebar_container.h View 1 2 3 5 chunks +29 lines, -12 lines 0 comments Download
M chrome/browser/sidebar/sidebar_container.cc View 1 2 3 5 chunks +44 lines, -11 lines 0 comments Download
M chrome/browser/sidebar/sidebar_manager.h View 1 2 3 5 chunks +54 lines, -64 lines 0 comments Download
M chrome/browser/sidebar/sidebar_manager.cc View 1 2 3 20 chunks +85 lines, -27 lines 0 comments Download
A chrome/browser/sidebar/sidebar_model.h View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/sidebar_controller.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/sidebar_controller.mm View 1 2 3 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/view_id_util_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/view_ids.h View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 9 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 11 chunks +83 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 2 3 8 chunks +125 lines, -44 lines 0 comments Download
A chrome/browser/ui/views/sidebar/browser_sidebar_tab_strip_controller.h View 1 2 3 1 chunk +87 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/browser_sidebar_tab_strip_controller.cc View 1 2 1 chunk +222 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/browser_sidebar_tab_strip_controller_unittest.cc View 1 2 1 chunk +300 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_base_tab.h View 1 2 1 chunk +136 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_base_tab.cc View 1 2 3 1 chunk +321 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_base_tab_strip.h View 1 2 3 1 chunk +143 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_base_tab_strip.cc View 1 2 3 1 chunk +198 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab.h View 1 2 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab.cc View 1 2 3 1 chunk +247 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_controller.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_renderer_data.h View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_strip.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_strip.cc View 1 2 3 1 chunk +223 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_strip_controller.h View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_strip_host.h View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_strip_host.cc View 1 2 3 1 chunk +88 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_strip_host_gtk.cc View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_strip_host_win.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/sidebar/sidebar_tab_test_helper.h View 1 2 1 chunk +142 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +33 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M views/animation/bounds_animator.h View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M views/animation/bounds_animator.cc View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download
M views/animation/bounds_animator_unittest.cc View 1 2 3 4 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Aleksey Shlyapnikov
Hi Peter, would you happen to have time to review this patch? Please check the ...
9 years, 10 months ago (2011-02-04 00:53:46 UTC) #1
Peter Kasting
On 2011/02/04 00:53:46, Aleksey Shlyapnikov wrote: > Hi Peter, would you happen to have time ...
9 years, 10 months ago (2011-02-04 01:50:38 UTC) #2
Peter Kasting
I added Ben, since major new things should probably get at least a high-level look ...
9 years, 10 months ago (2011-02-04 01:52:34 UTC) #3
Aleksey Shlyapnikov
On 2011/02/04 01:50:38, Peter Kasting wrote: > On 2011/02/04 00:53:46, Aleksey Shlyapnikov wrote: > > ...
9 years, 10 months ago (2011-02-04 01:52:59 UTC) #4
Aleksey Shlyapnikov
Scott suggested to talk to you first.
9 years, 10 months ago (2011-02-04 01:54:30 UTC) #5
Peter Kasting
On 2011/02/04 01:54:30, Aleksey Shlyapnikov wrote: > Scott suggested to talk to you first. Um... ...
9 years, 10 months ago (2011-02-04 01:55:19 UTC) #6
Aleksey Shlyapnikov
9 years, 10 months ago (2011-02-04 02:05:07 UTC) #7
I don't really know, I did not ask why, but seems like I should talk to Scott or
Ben then.

Powered by Google App Engine
This is Rietveld 408576698