FilePath: Remove most of ToWStringHack, adding a LossyDisplayName()

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 51b654a6732c7bc97581d109927f6b5536329a02..2e74293775ff051f4de727faa0c235d82255ea67 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1892,8 +1892,7 @@ void ExtensionService::ReportExtensionLoadError(
                   Source<Profile>(profile_),
                   Details<const std::string>(&error));
 
-  // TODO(port): note that this isn't guaranteed to work properly on Linux.
-  std::string path_str = WideToUTF8(extension_path.ToWStringHack());
+  std::string path_str = UTF16ToUTF8(extension_path.LossyDisplayName());

[Mark Mentovai, 2011/02/01 22:42:44]

16To8(LossyDisplayName) is frustrating.

I’m also seeing 16ToWide(LossyDisplayName) a bunch in this CL. Also frustrating.

[Mark Mentovai, 2011/02/01 22:54:55]

16To8(LossyDisplayName) is frustrating. On the Mac, it’s zero conversions for
the price of two. On Linux, you probably still need to involve that native
multibyte conversion.

I’m see a lot of 16ToWide(LossyDisplayName) too. Also frustrating.

Is it worth having LossyDisplayNameUTF8 and LossyDisplayNameW to avoid
conversions when possible?

   std::string message = base::StringPrintf(
       "Could not load extension from '%s'. %s",
       path_str.c_str(), error.c_str());