chrome/browser/metrics/metrics_log.cc - Issue 6246036: FilePath: Remove most of ToWStringHack, adding a LossyDisplayName()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 6246036: FilePath: Remove most of ToWStringHack, adding a LossyDisplayName() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_log.cc

diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc

index 01e1717c5904728dfd6ff23bf0b7acf6492d1c55..24f850d17f5b657de40da00a2d35703dc996bfbe 100644

--- a/chrome/browser/metrics/metrics_log.cc

+++ b/chrome/browser/metrics/metrics_log.cc

@@ -283,7 +283,7 @@ void MetricsLog::WritePluginList(

// testing unreleased new extensions.

WriteAttribute("name", CreateBase64Hash(UTF16ToUTF8(iter->name)));

WriteAttribute("filename",

- CreateBase64Hash(WideToUTF8(iter->path.BaseName().ToWStringHack())));

+ CreateBase64Hash(UTF16ToUTF8(iter->path.BaseName().LossyDisplayName())));

Mark Mentovai 2011/02/01 22:54:55 Watch the 80. This is not for display and is thus

WriteAttribute("version", UTF16ToUTF8(iter->version));

}