FilePath: Remove most of ToWStringHack, adding a LossyDisplayName()

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 1874 matching lines @@
 void ExtensionService::ReportExtensionLoadError(
     const FilePath& extension_path,
     const std::string &error,
     NotificationType type,
     bool be_noisy) {
   NotificationService* service = NotificationService::current();
   service->Notify(type,
                   Source<Profile>(profile_),
                   Details<const std::string>(&error));
 
-  // TODO(port): note that this isn't guaranteed to work properly on Linux.
-  std::string path_str = WideToUTF8(extension_path.ToWStringHack());
+  std::string path_str = UTF16ToUTF8(extension_path.LossyDisplayName());

[Mark Mentovai, 2011/02/01 22:42:44]

16To8(LossyDisplayName) is frustrating.

I’m also seeing 16ToWide(LossyDisplayName) a bunch in this CL. Also frustrating.

[Mark Mentovai, 2011/02/01 22:54:55]

16To8(LossyDisplayName) is frustrating. On the Mac, it’s zero conversions for
the price of two. On Linux, you probably still need to involve that native
multibyte conversion.

I’m see a lot of 16ToWide(LossyDisplayName) too. Also frustrating.

Is it worth having LossyDisplayNameUTF8 and LossyDisplayNameW to avoid
conversions when possible?

   std::string message = base::StringPrintf(
       "Could not load extension from '%s'. %s",
       path_str.c_str(), error.c_str());
   ExtensionErrorReporter::GetInstance()->ReportError(message, be_noisy);
 }
 
 void ExtensionService::DidCreateRenderViewForBackgroundPage(
     ExtensionHost* host) {
   OrphanedDevTools::iterator iter =
       orphaned_dev_tools_.find(host->extension()->id());
@@ skipping 78 matching lines @@
 }
 
 void ExtensionService::SetBeingUpgraded(const Extension* extension,
                                          bool value) {
   extension_runtime_data_[extension->id()].being_upgraded = value;
 }
 
 PropertyBag* ExtensionService::GetPropertyBag(const Extension* extension) {
   return &extension_runtime_data_[extension->id()].property_bag;
 }