Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 6243002: app: Remove animation header files. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

app: Remove animation header files. They were moved to ui/base/animation. Remove them now, since no one is including these files. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -645 lines) Patch
D app/animation.h View 1 chunk +0 lines, -105 lines 0 comments Download
D app/animation_container.h View 1 chunk +0 lines, -86 lines 0 comments Download
D app/animation_container_element.h View 1 chunk +0 lines, -30 lines 0 comments Download
D app/animation_container_observer.h View 1 chunk +0 lines, -27 lines 0 comments Download
D app/animation_delegate.h View 1 chunk +0 lines, -30 lines 0 comments Download
D app/linear_animation.h View 1 chunk +0 lines, -71 lines 0 comments Download
D app/multi_animation.h View 1 chunk +0 lines, -90 lines 0 comments Download
D app/slide_animation.h View 1 chunk +0 lines, -96 lines 0 comments Download
D app/test_animation_delegate.h View 1 chunk +0 lines, -45 lines 0 comments Download
D app/throb_animation.h View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 11 months ago (2011-01-15 05:52:09 UTC) #1
Ben Goodger (Google)
9 years, 11 months ago (2011-01-15 06:13:07 UTC) #2
LGTM

On Fri, Jan 14, 2011 at 9:52 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger, sky,
>
> Description:
> app: Remove animation header files.
>
> They were moved to ui/base/animation. Remove them now, since no one is
> including
> these files.
>
> BUG=None
> TEST=trybots
>
> Please review this at http://codereview.chromium.org/6243002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/app
>
> Affected files:
>  D app/animation.h
>  D app/animation_container.h
>  D app/animation_container_element.h
>  D app/animation_container_observer.h
>  D app/animation_delegate.h
>  D app/linear_animation.h
>  D app/multi_animation.h
>  D app/slide_animation.h
>  D app/test_animation_delegate.h
>  D app/throb_animation.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698