Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 6241018: Pull in gmock through DEPS (Closed)

Created:
9 years, 11 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Pull in gmock through DEPS README.chromium hints that we didn't do this previously because of gmock using svn externals. But maruel recently landed a patch that makes gclient --ignore-externals. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72866

Patch Set 1 #

Patch Set 2 : don't use svn mirror for now #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -38630 lines) Patch
M DEPS View 1 1 chunk +3 lines, -0 lines 2 comments Download
D testing/README.chromium View 1 1 chunk +0 lines, -35 lines 0 comments Download
D testing/gmock/CHANGES View 1 1 chunk +0 lines, -66 lines 0 comments Download
D testing/gmock/CMakeLists.txt View 1 1 chunk +0 lines, -155 lines 0 comments Download
D testing/gmock/CONTRIBUTORS View 1 1 chunk +0 lines, -40 lines 0 comments Download
D testing/gmock/COPYING View 1 1 chunk +0 lines, -28 lines 0 comments Download
D testing/gmock/Makefile.am View 1 1 chunk +0 lines, -187 lines 0 comments Download
D testing/gmock/README View 1 1 chunk +0 lines, -352 lines 0 comments Download
D testing/gmock/build-aux/.keep View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D testing/gmock/configure.ac View 1 1 chunk +0 lines, -146 lines 0 comments Download
D testing/gmock/include/gmock/gmock.h View 1 1 chunk +0 lines, -93 lines 0 comments Download
D testing/gmock/include/gmock/gmock-actions.h View 1 1 chunk +0 lines, -1027 lines 0 comments Download
D testing/gmock/include/gmock/gmock-cardinalities.h View 1 1 chunk +0 lines, -146 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-actions.h View 1 1 chunk +0 lines, -2419 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-actions.h.pump View 1 1 chunk +0 lines, -825 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-function-mockers.h View 1 1 chunk +0 lines, -924 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-function-mockers.h.pump View 1 1 chunk +0 lines, -257 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-matchers.h View 1 1 chunk +0 lines, -1848 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-matchers.h.pump View 1 1 chunk +0 lines, -597 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-nice-strict.h View 1 1 chunk +0 lines, -274 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-nice-strict.h.pump View 1 1 chunk +0 lines, -160 lines 0 comments Download
D testing/gmock/include/gmock/gmock-matchers.h View 1 1 chunk +0 lines, -3154 lines 0 comments Download
D testing/gmock/include/gmock/gmock-more-actions.h View 1 1 chunk +0 lines, -220 lines 0 comments Download
D testing/gmock/include/gmock/gmock-spec-builders.h View 1 1 chunk +0 lines, -1853 lines 0 comments Download
D testing/gmock/include/gmock/internal/gmock-generated-internal-utils.h View 1 1 chunk +0 lines, -277 lines 0 comments Download
D testing/gmock/include/gmock/internal/gmock-generated-internal-utils.h.pump View 1 1 chunk +0 lines, -136 lines 0 comments Download
D testing/gmock/include/gmock/internal/gmock-internal-utils.h View 1 1 chunk +0 lines, -473 lines 0 comments Download
D testing/gmock/include/gmock/internal/gmock-port.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D testing/gmock/make/Makefile View 1 1 chunk +0 lines, -98 lines 0 comments Download
D testing/gmock/msvc/gmock.sln View 1 1 chunk +0 lines, -44 lines 0 comments Download
D testing/gmock/msvc/gmock.vcproj View 1 1 chunk +0 lines, -263 lines 0 comments Download
D testing/gmock/msvc/gmock-spec-builders_test.vcproj View 1 1 chunk +0 lines, -205 lines 0 comments Download
D testing/gmock/msvc/gmock_config.vsprops View 1 1 chunk +0 lines, -15 lines 0 comments Download
D testing/gmock/msvc/gmock_link_test.vcproj View 1 1 chunk +0 lines, -203 lines 0 comments Download
D testing/gmock/msvc/gmock_main.vcproj View 1 1 chunk +0 lines, -187 lines 0 comments Download
D testing/gmock/msvc/gmock_test.vcproj View 1 1 chunk +0 lines, -243 lines 0 comments Download
D testing/gmock/run_tests.py View 1 1 chunk +0 lines, -81 lines 0 comments Download
D testing/gmock/scripts/fuse_gmock_files.py View 1 1 chunk +0 lines, -240 lines 0 comments Download
D testing/gmock/scripts/generator/COPYING View 1 1 chunk +0 lines, -203 lines 0 comments Download
D testing/gmock/scripts/generator/README View 1 1 chunk +0 lines, -35 lines 0 comments Download
D testing/gmock/scripts/generator/README.cppclean View 1 1 chunk +0 lines, -115 lines 0 comments Download
D testing/gmock/scripts/generator/cpp/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D testing/gmock/scripts/generator/cpp/ast.py View 1 1 chunk +0 lines, -1717 lines 0 comments Download
D testing/gmock/scripts/generator/cpp/gmock_class.py View 1 1 chunk +0 lines, -178 lines 0 comments Download
D testing/gmock/scripts/generator/cpp/gmock_class_test.py View 1 1 chunk +0 lines, -137 lines 0 comments Download
D testing/gmock/scripts/generator/cpp/keywords.py View 1 1 chunk +0 lines, -59 lines 0 comments Download
D testing/gmock/scripts/generator/cpp/tokenize.py View 1 1 chunk +0 lines, -287 lines 0 comments Download
D testing/gmock/scripts/generator/cpp/utils.py View 1 1 chunk +0 lines, -41 lines 0 comments Download
D testing/gmock/scripts/generator/gmock_gen.py View 1 1 chunk +0 lines, -31 lines 0 comments Download
D testing/gmock/scripts/gmock-config.in View 1 1 chunk +0 lines, -303 lines 0 comments Download
D testing/gmock/scripts/gmock_doctor.py View 1 1 chunk +0 lines, -519 lines 0 comments Download
D testing/gmock/scripts/upload.py View 1 1 chunk +0 lines, -1387 lines 0 comments Download
D testing/gmock/scripts/upload_gmock.py View 1 1 chunk +0 lines, -78 lines 0 comments Download
D testing/gmock/src/gmock.cc View 1 1 chunk +0 lines, -182 lines 0 comments Download
D testing/gmock/src/gmock-all.cc View 1 1 chunk +0 lines, -47 lines 0 comments Download
D testing/gmock/src/gmock-cardinalities.cc View 1 1 chunk +0 lines, -155 lines 0 comments Download
D testing/gmock/src/gmock-internal-utils.cc View 1 1 chunk +0 lines, -173 lines 0 comments Download
D testing/gmock/src/gmock-matchers.cc View 1 1 chunk +0 lines, -190 lines 0 comments Download
D testing/gmock/src/gmock-spec-builders.cc View 1 1 chunk +0 lines, -465 lines 0 comments Download
D testing/gmock/src/gmock_main.cc View 1 1 chunk +0 lines, -54 lines 0 comments Download
D testing/gmock/test/gmock-actions_test.cc View 1 1 chunk +0 lines, -1083 lines 0 comments Download
D testing/gmock/test/gmock-cardinalities_test.cc View 1 1 chunk +0 lines, -428 lines 0 comments Download
D testing/gmock/test/gmock-generated-actions_test.cc View 1 1 chunk +0 lines, -1212 lines 0 comments Download
D testing/gmock/test/gmock-generated-function-mockers_test.cc View 1 1 chunk +0 lines, -540 lines 0 comments Download
D testing/gmock/test/gmock-generated-internal-utils_test.cc View 1 1 chunk +0 lines, -127 lines 0 comments Download
D testing/gmock/test/gmock-generated-matchers_test.cc View 1 1 chunk +0 lines, -1153 lines 0 comments Download
D testing/gmock/test/gmock-internal-utils_test.cc View 1 1 chunk +0 lines, -652 lines 0 comments Download
D testing/gmock/test/gmock-matchers_test.cc View 1 1 chunk +0 lines, -4200 lines 0 comments Download
D testing/gmock/test/gmock-more-actions_test.cc View 1 1 chunk +0 lines, -668 lines 0 comments Download
D testing/gmock/test/gmock-nice-strict_test.cc View 1 1 chunk +0 lines, -284 lines 0 comments Download
D testing/gmock/test/gmock-port_test.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
D testing/gmock/test/gmock-spec-builders_test.cc View 1 1 chunk +0 lines, -2404 lines 0 comments Download
D testing/gmock/test/gmock_all_test.cc View 1 1 chunk +0 lines, -48 lines 0 comments Download
D testing/gmock/test/gmock_leak_test.py View 1 1 chunk +0 lines, -90 lines 0 comments Download
D testing/gmock/test/gmock_leak_test_.cc View 1 1 chunk +0 lines, -100 lines 0 comments Download
D testing/gmock/test/gmock_link2_test.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
D testing/gmock/test/gmock_link_test.h View 1 1 chunk +0 lines, -669 lines 0 comments Download
D testing/gmock/test/gmock_link_test.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
D testing/gmock/test/gmock_output_test.py View 1 1 chunk +0 lines, -180 lines 0 comments Download
D testing/gmock/test/gmock_output_test_.cc View 1 1 chunk +0 lines, -290 lines 0 comments Download
D testing/gmock/test/gmock_output_test_golden.txt View 1 1 chunk +0 lines, -310 lines 0 comments Download
D testing/gmock/test/gmock_test.cc View 1 1 chunk +0 lines, -255 lines 0 comments Download
D testing/gmock/test/gmock_test_utils.py View 1 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Works fine locally. I have a thread open with the infrastructure folks about the try ...
9 years, 11 months ago (2011-01-27 19:02:40 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/6241018/diff/66002/DEPS File DEPS (right): http://codereview.chromium.org/6241018/diff/66002/DEPS#newcode37 DEPS:37: "http://googlemock.googlecode.com/svn/trunk@300", README.chromium says current revision 282. Does it ...
9 years, 11 months ago (2011-01-27 19:35:43 UTC) #2
Nico
thanks! http://codereview.chromium.org/6241018/diff/66002/DEPS File DEPS (right): http://codereview.chromium.org/6241018/diff/66002/DEPS#newcode37 DEPS:37: "http://googlemock.googlecode.com/svn/trunk@300", On 2011/01/27 19:35:44, Evan Martin wrote: > ...
9 years, 11 months ago (2011-01-27 19:42:21 UTC) #3
Evan Martin
9 years, 11 months ago (2011-01-27 19:48:58 UTC) #4
On Thu, Jan 27, 2011 at 11:42 AM,  <thakis@chromium.org> wrote:
> Yes, it matters. 282 doesn't work. (It got updated in
> http://codereview.chromium.org/3427004 to 300, but both reviewer and
> patch author failed to notice that the readme needed to be updated ;-) )

I think the reviewer is completely at fault there and the author is blameless!

LGTM++

Powered by Google App Engine
This is Rietveld 408576698