Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 3427004: clang: update gtest/gmock (Closed)

Created:
10 years, 3 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

clang: update gtest to r435 and gmock to r300. This picks up some clang-specific fixes. Unfortunately, the gtest update cascaded into a gmock update. So I picked the earliest gmock version that mentioned a specific gtest version so that they are more likely to work together. gtest changelog: - Fixes a leak in ThreadLocal. - CMake 2.8/Visual Age compatibility patch by Hady Zalek. - C++ Builder compatibility patch by Josh Kelley. - Fixes gtest_filter_unittest and gtest_help_test on systems without death tests. - Simplifies Makefile.am (by Zhanyong Wan and Vlad Losev). - Adds alternative spellings for FAIL, SUCCEED, and TEST. - Over-hauls README, and fixes Makefile. - Fixes gtest-port_test on MinGW. - Implements color output in GNU Screen sessions (issue 277). - Minor improvement to hermetic build support in the CMake script, by Vlad Losev. - Improves support for building Google Test as Windows DLL. - Silence a Clang warning about an unused variable. - Moves the universal printer from gmock to gtest and refactors the cmake script for reusing in gmock (by Vlad Losev). - Suppresses some Clang warnings (by Chandler Carruth, Jeffrey Yasskin, and Zhanyong Wan). - Renames CMake build script options. - Lucid autotools compatibility patch by Jeffrey Yasskin. - Replaces UniversalPrinter<T>::Print(x, os) with UniversalPrint(x, os) as appropriate (by Zhanyong Wan). - Comment tweaks in CMakeLists.txt. - Renames test script flags. - Fixes a typo in comments. - Adds GTEST_REMOVE_REFERENCE_AND_CONST_. - Introduces gtest_force_shared_crt option for CMake build scripts. - Implements printing parameters of failed parameterized tests (issue 71). gmock changelog: - Improves Makefile.am (by Vlad Losev); fixes Makefile and updates README (by Zhanyong Wan). - Fixes a typo in README. - Adds Each(m) (by Wojtek Moczydlowski); removes scripts/test/Makefile (by Zhanyong Wan); pulls in gtest r424. - Adds a synchronization test. - Fixes tests leaking altered values of GMOCK_FLAG(verbose) (issue 110). - Moves the universal printer from gmock to gtest (by Vlad Losev). - Renames test script flags. - Adds CMake build script. - Implements Pointwise(). - Fixes build failure on Windows/CMake (issue 111). - Pulls r435 of gtest. This brings in the gtest_force_shared_crt option in CMake. TEST=all existing tests should still pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59701

Patch Set 1 #

Patch Set 2 : yakshave #

Patch Set 3 : yakshave #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1121 lines, -3519 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
A testing/gmock/CMakeLists.txt View 1 chunk +155 lines, -0 lines 0 comments Download
M testing/gmock/Makefile.am View 5 chunks +42 lines, -9 lines 0 comments Download
M testing/gmock/README View 5 chunks +240 lines, -150 lines 0 comments Download
M testing/gmock/include/gmock/gmock.h View 1 chunk +0 lines, -1 line 0 comments Download
M testing/gmock/include/gmock/gmock-actions.h View 5 chunks +4 lines, -5 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-function-mockers.h View 11 chunks +11 lines, -11 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-function-mockers.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h View 12 chunks +11 lines, -22 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h.pump View 3 chunks +2 lines, -4 lines 0 comments Download
M testing/gmock/include/gmock/gmock-matchers.h View 26 chunks +310 lines, -76 lines 0 comments Download
M testing/gmock/include/gmock/gmock-more-actions.h View 2 chunks +11 lines, -1 line 0 comments Download
D testing/gmock/include/gmock/gmock-printers.h View 1 chunk +0 lines, -725 lines 0 comments Download
M testing/gmock/include/gmock/gmock-spec-builders.h View 4 chunks +3 lines, -3 lines 0 comments Download
M testing/gmock/include/gmock/internal/gmock-internal-utils.h View 8 chunks +3 lines, -293 lines 0 comments Download
M testing/gmock/include/gmock/internal/gmock-port.h View 1 chunk +0 lines, -137 lines 0 comments Download
M testing/gmock/make/Makefile View 3 chunks +9 lines, -20 lines 0 comments Download
A testing/gmock/msvc/gmock-spec-builders_test.vcproj View 0 chunks +-1 lines, --1 lines 0 comments Download
M testing/gmock/run_tests.py View 1 chunk +0 lines, -1 line 0 comments Download
A testing/gmock/scripts/gmock-config.in View 0 chunks +-1 lines, --1 lines 0 comments Download
M testing/gmock/scripts/gmock_doctor.py View 1 chunk +1 line, -1 line 0 comments Download
D testing/gmock/scripts/test/Makefile View 1 chunk +0 lines, -57 lines 0 comments Download
M testing/gmock/src/gmock-all.cc View 1 chunk +0 lines, -1 line 0 comments Download
D testing/gmock/src/gmock-printers.cc View 1 chunk +0 lines, -318 lines 0 comments Download
M testing/gmock/test/gmock-actions_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M testing/gmock/test/gmock-generated-matchers_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M testing/gmock/test/gmock-internal-utils_test.cc View 5 chunks +4 lines, -307 lines 0 comments Download
M testing/gmock/test/gmock-matchers_test.cc View 25 chunks +258 lines, -46 lines 0 comments Download
M testing/gmock/test/gmock-nice-strict_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M testing/gmock/test/gmock-port_test.cc View 1 chunk +1 line, -122 lines 0 comments Download
D testing/gmock/test/gmock-printers_test.cc View 1 chunk +0 lines, -1118 lines 0 comments Download
M testing/gmock/test/gmock-spec-builders_test.cc View 4 chunks +37 lines, -17 lines 0 comments Download
M testing/gmock/test/gmock_all_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M testing/gmock/test/gmock_output_test.py View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/test/gmock_output_test_golden.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M testing/gmock/test/gmock_test_utils.py View 3 chunks +2 lines, -58 lines 0 comments Download
M testing/gtest.gyp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Martin
10 years, 3 months ago (2010-09-14 23:10:24 UTC) #1
Nico
lg (cl description says 426 but code says 428)
10 years, 3 months ago (2010-09-14 23:16:55 UTC) #2
Evan Martin
argh, gmock fail. will try again
10 years, 3 months ago (2010-09-14 23:17:12 UTC) #3
Evan Martin
Why does it always have to be a yak shave. :< This one builds locally, ...
10 years, 3 months ago (2010-09-14 23:58:03 UTC) #4
Nico
slg
10 years, 3 months ago (2010-09-15 00:06:26 UTC) #5
Nico
10 years, 3 months ago (2010-09-15 00:06:42 UTC) #6
(i'm a bit surprised that we don't pull gmock via deps)

Powered by Google App Engine
This is Rietveld 408576698