Issue 6186008: Linux: fix a bunch of NULL vs. 0 issues spotted by gcc 4.5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6186008: Linux: fix a bunch of NULL vs. 0 issues spotted by gcc 4.5. (Closed)

Created:
9 years, 11 months ago by Craig

Modified:
9 years, 7 months ago

Reviewers:
hans, Nico

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Paweł Hajdan Jr., jam, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Linux: fix a bunch of NULL vs. 0 issues spotted by gcc 4.5. There are more gcc 4.5 issues to be solved so GYP_DEFINES=='werror=' is still required to build with 4.5 even with these changes. BUG=66652 TEST=compiles with gcc 4.5 and trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71325

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -27 lines)			Patch
M	app/gtk_dnd_util_unittest.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/options/languages_page_gtk_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/top_sites.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ppapi_plugin_process_host.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/process_singleton_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/syncable/syncable.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/tabs/dock_info_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/plugin_messages.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/pepper_plugin_delegate_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	courgette/streams_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	ipc/ipc_tests.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Craig

Anyone keen to review this please? 99% of it should be really obvious. Thanks!!! PS. ...

9 years, 11 months ago (2011-01-12 18:14:44 UTC) #1

hans

9 years, 11 months ago (2011-01-12 18:23:00 UTC) #3

On 2011/01/12 18:14:44, Craig wrote:
> Anyone keen to review this please? 99% of it should be really obvious.
Thanks!!!
> 
> PS. The EXPECT_FALSE changes are recommended by
> http://code.google.com/p/googletest/issues/detail?id=322

LGTM

Expand Messages | Collapse Messages