Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2177)

Unified Diff: app/gtk_dnd_util_unittest.cc

Issue 6186008: Linux: fix a bunch of NULL vs. 0 issues spotted by gcc 4.5. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider_observers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/gtk_dnd_util_unittest.cc
diff --git a/app/gtk_dnd_util_unittest.cc b/app/gtk_dnd_util_unittest.cc
index 1de8991829628aec2246510654b3ab2e09f32d38..cefc6dd332c3d8f856e629eb633c247753770ddf 100644
--- a/app/gtk_dnd_util_unittest.cc
+++ b/app/gtk_dnd_util_unittest.cc
@@ -46,7 +46,7 @@ TEST(GtkDndUtilTest, ExtractNamedURLInvalidURL) {
GURL url;
string16 title;
- EXPECT_EQ(false, gtk_dnd_util::ExtractNamedURL(&data, &url, &title));
+ EXPECT_FALSE(gtk_dnd_util::ExtractNamedURL(&data, &url, &title));
}
TEST(GtkDndUtilTest, ExtractNamedURLInvalidInput) {
@@ -56,13 +56,13 @@ TEST(GtkDndUtilTest, ExtractNamedURLInvalidInput) {
data.data = NULL;
data.length = 0;
- EXPECT_EQ(false, gtk_dnd_util::ExtractNamedURL(&data, &url, &title));
+ EXPECT_FALSE(gtk_dnd_util::ExtractNamedURL(&data, &url, &title));
guchar empty_data[] = "";
data.data = empty_data;
data.length = 0;
- EXPECT_EQ(false, gtk_dnd_util::ExtractNamedURL(&data, &url, &title));
+ EXPECT_FALSE(gtk_dnd_util::ExtractNamedURL(&data, &url, &title));
const std::string kTitle = "title";
Pickle pickle;
@@ -73,5 +73,5 @@ TEST(GtkDndUtilTest, ExtractNamedURLInvalidInput) {
data.data = test_data.get();
data.length = pickle.size();
- EXPECT_EQ(false, gtk_dnd_util::ExtractNamedURL(&data, &url, &title));
+ EXPECT_FALSE(gtk_dnd_util::ExtractNamedURL(&data, &url, &title));
}
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider_observers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698