chrome/browser/ui/tabs/dock_info_unittest.cc - Issue 6186008: Linux: fix a bunch of NULL vs. 0 issues spotted by gcc 4.5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/dock_info_unittest.cc

Issue 6186008: Linux: fix a bunch of NULL vs. 0 issues spotted by gcc 4.5. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/dock_info_unittest.cc

diff --git a/chrome/browser/ui/tabs/dock_info_unittest.cc b/chrome/browser/ui/tabs/dock_info_unittest.cc

index ee4557e4cfa0d9fe32284473e4b218feb5988be9..8bb52a5ca9dd4191936e9a214b0552aa6868c43b 100644

--- a/chrome/browser/ui/tabs/dock_info_unittest.cc

+++ b/chrome/browser/ui/tabs/dock_info_unittest.cc

@@ -101,7 +101,7 @@ TEST(DockInfoTest, IsCloseToMonitorPoint) {

TEST(DockInfoTest, IsValidForPoint) {

DockInfo d;

- EXPECT_EQ(false, d.IsValidForPoint(gfx::Point(0, 0)));

+ EXPECT_FALSE(d.IsValidForPoint(gfx::Point(0, 0)));

d.set_monitor_bounds(gfx::Rect(0, 0, kPopupWidth, kPopupHeight));

d.set_hot_spot(gfx::Point(0, 0));

d.set_type(DockInfo::LEFT_HALF);

@@ -126,7 +126,7 @@ TEST(DockInfoTest, equals) {

DockInfo dd;

EXPECT_EQ(true, d.equals(dd));

d.set_type(DockInfo::MAXIMIZE);

- EXPECT_EQ(false, d.equals(dd));

+ EXPECT_FALSE(d.equals(dd));

}

TEST(DockInfoTest, CheckMonitorPoint) {

« no previous file with comments | « chrome/browser/sync/syncable/syncable.cc ('k') | chrome/common/plugin_messages.cc » ('j') | no next file with comments »