Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: media/base/filters.h

Issue 6171009: Remove MessageLoop methods from Filter interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Applied more CR suggestions & removed message_loop() methods where possible. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/composite_filter_unittest.cc ('k') | media/base/filters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.h
diff --git a/media/base/filters.h b/media/base/filters.h
index 49fa3472f31de0927cc7924f88abfa6aadefefcc..84c466d63e6cf6994961fe4630bf32997c37fc76 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -33,8 +33,6 @@
#include "media/base/media_format.h"
#include "media/base/video_frame.h"
-class MessageLoop;
-
namespace media {
class Buffer;
@@ -61,20 +59,6 @@ class Filter : public base::RefCountedThreadSafe<Filter> {
virtual FilterHost* host();
- // Indicates whether this filter requires a message loop to operate.
- virtual bool requires_message_loop() const;
-
- // The name to associate with this filter's message loop.
- virtual const char* message_loop_name() const;
-
- // Sets the private member |message_loop_|, which is used by filters for
- // processing asynchronous tasks and maintaining synchronized access to
- // internal data members. The message loop should be running and exceed the
- // lifetime of the filter.
- virtual void set_message_loop(MessageLoop* message_loop);
-
- virtual MessageLoop* message_loop();
-
// The pipeline has resumed playback. Filters can continue requesting reads.
// Filters may implement this method if they need to respond to this call.
// TODO(boliu): Check that callback is not NULL in subclasses.
@@ -114,11 +98,9 @@ class Filter : public base::RefCountedThreadSafe<Filter> {
virtual ~Filter();
FilterHost* host() const { return host_; }
- MessageLoop* message_loop() const { return message_loop_; }
private:
FilterHost* host_;
- MessageLoop* message_loop_;
DISALLOW_COPY_AND_ASSIGN(Filter);
};
@@ -154,9 +136,6 @@ class DataSource : public Filter {
class Demuxer : public Filter {
public:
- virtual bool requires_message_loop() const;
- virtual const char* message_loop_name() const;
-
// Initialize a Demuxer with the given DataSource, executing the callback upon
// completion.
virtual void Initialize(DataSource* data_source,
@@ -211,9 +190,6 @@ class DemuxerStream : public base::RefCountedThreadSafe<DemuxerStream> {
class VideoDecoder : public Filter {
public:
virtual const char* major_mime_type() const;
- virtual bool requires_message_loop() const;
- virtual const char* message_loop_name() const;
-
// Initialize a VideoDecoder with the given DemuxerStream, executing the
// callback upon completion.
@@ -256,8 +232,6 @@ class VideoDecoder : public Filter {
class AudioDecoder : public Filter {
public:
virtual const char* major_mime_type() const;
- virtual bool requires_message_loop() const;
- virtual const char* message_loop_name() const;
// Initialize a AudioDecoder with the given DemuxerStream, executing the
// callback upon completion.
« no previous file with comments | « media/base/composite_filter_unittest.cc ('k') | media/base/filters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698