Remove MessageLoop methods from Filter interface

media/base/filters.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Filters are connected in a strongly typed manner, with downstream filters
 // always reading data from upstream filters.  Upstream filters have no clue
 // who is actually reading from them, and return the results via callbacks.
 //
 //                         DemuxerStream(Video) <- VideoDecoder <- VideoRenderer
 // DataSource <- Demuxer <
@@ skipping 15 matching lines @@
 #include <limits>
 #include <string>
 
 #include "base/callback.h"
 #include "base/ref_counted.h"
 #include "base/time.h"
 #include "base/scoped_ptr.h"
 #include "media/base/media_format.h"
 #include "media/base/video_frame.h"
 
-class MessageLoop;
-
 namespace media {
 
 class Buffer;
 class Decoder;
 class DemuxerStream;
 class Filter;
 class FilterHost;
 
 // Used for completing asynchronous methods.
 typedef Callback0::Type FilterCallback;
 
 class Filter : public base::RefCountedThreadSafe<Filter> {
  public:
   Filter();
 
   // Return the major mime type for this filter.
   virtual const char* major_mime_type() const;
 
   // Sets the private member |host_|. This is the first method called by
   // the FilterHost after a filter is created.  The host holds a strong
   // reference to the filter.  The reference held by the host is guaranteed
   // to be released before the host object is destroyed by the pipeline.
   virtual void set_host(FilterHost* host);
 
   virtual FilterHost* host();
 
-  // Indicates whether this filter requires a message loop to operate.
-  virtual bool requires_message_loop() const;
-
-  // The name to associate with this filter's message loop.
-  virtual const char* message_loop_name() const;
-
-  // Sets the private member |message_loop_|, which is used by filters for
-  // processing asynchronous tasks and maintaining synchronized access to
-  // internal data members.  The message loop should be running and exceed the
-  // lifetime of the filter.
-  virtual void set_message_loop(MessageLoop* message_loop);
-
-  virtual MessageLoop* message_loop();
-
   // The pipeline has resumed playback.  Filters can continue requesting reads.
   // Filters may implement this method if they need to respond to this call.
   // TODO(boliu): Check that callback is not NULL in subclasses.
   virtual void Play(FilterCallback* callback);
 
   // The pipeline has paused playback.  Filters should stop buffer exchange.
   // Filters may implement this method if they need to respond to this call.
   // TODO(boliu): Check that callback is not NULL in subclasses.
   virtual void Pause(FilterCallback* callback);
 
@@ skipping 19 matching lines @@
   // is disabled. Filters can ignore the notification if they do not
   // need to react to this event.
   virtual void OnAudioRendererDisabled();
 
  protected:
   // Only allow scoped_refptr<> to delete filters.
   friend class base::RefCountedThreadSafe<Filter>;
   virtual ~Filter();
 
   FilterHost* host() const { return host_; }
-  MessageLoop* message_loop() const { return message_loop_; }
 
  private:
   FilterHost* host_;
-  MessageLoop* message_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(Filter);
 };
 
 class DataSource : public Filter {
  public:
   typedef Callback1<size_t>::Type ReadCallback;
   static const size_t kReadError = static_cast<size_t>(-1);
 
   virtual bool IsUrlSupported(const std::string& url);
@@ skipping 15 matching lines @@
   virtual bool GetSize(int64* size_out) = 0;
 
   // Returns true if we are performing streaming. In this case seeking is
   // not possible.
   virtual bool IsStreaming() = 0;
 };
 
 
 class Demuxer : public Filter {
  public:
-  virtual bool requires_message_loop() const;
-  virtual const char* message_loop_name() const;
-
   // Initialize a Demuxer with the given DataSource, executing the callback upon
   // completion.
   virtual void Initialize(DataSource* data_source,
                           FilterCallback* callback) = 0;
 
   // Returns the number of streams available
   virtual size_t GetNumberOfStreams() = 0;
 
   // Returns the stream for the given index, NULL otherwise
   virtual scoped_refptr<DemuxerStream> GetStream(int stream_id) = 0;
@@ skipping 34 matching lines @@
   virtual void* QueryInterface(const char* interface_id);
 
   friend class base::RefCountedThreadSafe<DemuxerStream>;
   virtual ~DemuxerStream();
 };
 
 
 class VideoDecoder : public Filter {
  public:
   virtual const char* major_mime_type() const;
-  virtual bool requires_message_loop() const;
-  virtual const char* message_loop_name() const;
-
 
   // Initialize a VideoDecoder with the given DemuxerStream, executing the
   // callback upon completion.
   virtual void Initialize(DemuxerStream* stream, FilterCallback* callback) = 0;
 
   // |set_fill_buffer_done_callback| install permanent callback from downstream
   // filter (i.e. Renderer). The callback is used to deliver video frames at
   // runtime to downstream filter
   typedef Callback1<scoped_refptr<VideoFrame> >::Type ConsumeVideoFrameCallback;
   void set_consume_video_frame_callback(ConsumeVideoFrameCallback* callback) {
@@ skipping 22 matching lines @@
   virtual ~VideoDecoder();
 
  private:
   scoped_ptr<ConsumeVideoFrameCallback> consume_video_frame_callback_;
 };
 
 
 class AudioDecoder : public Filter {
  public:
   virtual const char* major_mime_type() const;
-  virtual bool requires_message_loop() const;
-  virtual const char* message_loop_name() const;
 
   // Initialize a AudioDecoder with the given DemuxerStream, executing the
   // callback upon completion.
   virtual void Initialize(DemuxerStream* stream, FilterCallback* callback) = 0;
 
   // |set_fill_buffer_done_callback| install permanent callback from downstream
   // filter (i.e. Renderer). The callback is used to deliver buffers at
   // runtime to downstream filter.
   typedef Callback1<scoped_refptr<Buffer> >::Type ConsumeAudioSamplesCallback;
   void set_consume_audio_samples_callback(
@@ skipping 47 matching lines @@
   // buffer.
   virtual bool HasEnded() = 0;
 
   // Sets the output volume.
   virtual void SetVolume(float volume) = 0;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_FILTERS_H_