Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: media/base/filters.cc

Issue 6171009: Remove MessageLoop methods from Filter interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Applied more CR suggestions & removed message_loop() methods where possible. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/filters.h ('k') | media/base/message_loop_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.cc
diff --git a/media/base/filters.cc b/media/base/filters.cc
index d3d3bcbc3c34521a949c69e3a6390bd7e4c77ff4..eff50b4f8635581216245aa63310a30eeb7f2171 100644
--- a/media/base/filters.cc
+++ b/media/base/filters.cc
@@ -5,11 +5,10 @@
#include "media/base/filters.h"
#include "base/logging.h"
-#include "base/message_loop.h"
namespace media {
-Filter::Filter() : host_(NULL), message_loop_(NULL) {}
+Filter::Filter() : host_(NULL) {}
Filter::~Filter() {}
@@ -27,24 +26,6 @@ FilterHost* Filter::host() {
return host_;
}
-bool Filter::requires_message_loop() const {
- return false;
-}
-
-const char* Filter::message_loop_name() const {
- return "FilterThread";
-}
-
-void Filter::set_message_loop(MessageLoop* message_loop) {
- DCHECK(message_loop);
- DCHECK(!message_loop_);
- message_loop_ = message_loop;
-}
-
-MessageLoop* Filter::message_loop() {
- return message_loop_;
-}
-
void Filter::Play(FilterCallback* callback) {
DCHECK(callback);
if (callback) {
@@ -93,26 +74,10 @@ bool DataSource::IsUrlSupported(const std::string& url) {
return true;
}
-bool Demuxer::requires_message_loop() const {
- return true;
-}
-
-const char* Demuxer::message_loop_name() const {
- return "DemuxerThread";
-}
-
const char* AudioDecoder::major_mime_type() const {
return mime_type::kMajorTypeAudio;
}
-bool AudioDecoder::requires_message_loop() const {
- return true;
-}
-
-const char* AudioDecoder::message_loop_name() const {
- return "AudioDecoderThread";
-}
-
const char* AudioRenderer::major_mime_type() const {
return mime_type::kMajorTypeAudio;
}
@@ -121,14 +86,6 @@ const char* VideoDecoder::major_mime_type() const {
return mime_type::kMajorTypeVideo;
}
-bool VideoDecoder::requires_message_loop() const {
- return true;
-}
-
-const char* VideoDecoder::message_loop_name() const {
- return "VideoDecoderThread";
-}
-
const char* VideoRenderer::major_mime_type() const {
return mime_type::kMajorTypeVideo;
}
« no previous file with comments | « media/base/filters.h ('k') | media/base/message_loop_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698